Skip to content

Inline copy_to_operands #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Inline copy_to_operands #3074

merged 1 commit into from
Oct 1, 2018

Conversation

kroening
Copy link
Member

@kroening kroening commented Oct 1, 2018

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening requested a review from tautschnig October 1, 2018 11:30
@kroening kroening changed the title Inline copy to operands Inline copy_to_operands Oct 1, 2018
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have "requested changes" on #3073 so cannot yet approve this one I guess ;-) - but it looks ok except for what I said in #3073, which is the first commit of this one.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 5b26875).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86462274

There may be a performance benefit to enabling the compiler to inline these
frequenly used and short methods.
@kroening kroening force-pushed the inline_copy_to_operands branch from 5b26875 to d178327 Compare October 1, 2018 14:05
@kroening
Copy link
Member Author

kroening commented Oct 1, 2018

@tautschnig I've dropped the first commit off this one, then you don't need to feel conflicted.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: d178327).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86484902

@kroening kroening merged commit 273f375 into develop Oct 1, 2018
@kroening kroening deleted the inline_copy_to_operands branch October 1, 2018 17:12
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: d178327).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86497015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants