Error handling cleanup in solvers/flattening 7 #2944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpoe
requested review from
kroening,
martin-cs,
peterschrammel and
tautschnig
as code owners
peterschrammel
approved these changes
Sep 17, 2018
tautschnig
requested changes
Sep 19, 2018
src/solvers/flattening/equality.cpp
Outdated
| @@ -24,10 +24,9 @@ literalt equalityt::equality(const exprt &e1, const exprt &e2) | |||
|
|
|||
| literalt equalityt::equality2(const exprt &e1, const exprt &e2) | |||
| { | |||
| const typet &type=e1.type(); | |||
| PRECONDITION(e2.type() != e1.type()); | |||
There was a problem hiding this comment.
Those better be equal ;-)
src/solvers/flattening/equality.cpp
Outdated
| throw "equalityt got boolean equality"; | ||
| // return lequal(convert(e1), convert(e2)); | ||
| INVARIANT( | ||
| type.id() != ID_bool, "method shall not be used to compare boolean types"); |
| INVARIANT_WITH_DIAGNOSTICS( | ||
| false, | ||
| "flatten_byte_update should only be used on arrays of scalars", | ||
| subtype.id_string()); |
There was a problem hiding this comment.
No, it can soundly be used on other types, it's just not yet implemented...
Files equality.cpp to pointer_logic.h
danpoe
force-pushed
the
refactor/error-handling-solvers-flattening-from-boolbv-equality
branch
from
0ccb8e8 to
d07bba7
Compare
allredj
reviewed
Sep 21, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: d07bba7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85574428
|
@tautschnig I think this is ready to be merged. |
tautschnig
approved these changes
Sep 28, 2018
danpoe
deleted the
refactor/error-handling-solvers-flattening-from-boolbv-equality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.