Skip to content

Run strings-smoke-tests #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2018
Merged

Run strings-smoke-tests #2556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c75b47
Run strings-smoke-tests and janalyzer tests
peterschrammel Jun 22, 2018
f1afbff
Remove unnecessary PLATFORM_DIRS
peterschrammel Jul 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions jbmc/regression/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,27 @@
# For the best possible utilisation of multiple cores when
# running tests in parallel, it is important that these directories are
# listed with decreasing runtimes (i.e. longest running at the top)
DIRS = janalzyer-taint \
DIRS = janalyzer-taint \
jbmc \
jbmc-concurrency \
jbmc-cover \
jbmc-inheritance \
jbmc-strings \
jdiff \
string-smoke-tests \
strings-smoke-tests \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to remove lines 15-18 in this Makefile as they 1) are unnecessary and 2) removing them would have made this problem surface earlier.

jbmc-generics \
# Empty last line

# Tests under goto-gcc cannot be run on Windows, so appveyor.yml unlinks
# the entire directory under Windows. This variable will contain the list
# of directories that actually exist on the current platform.
PLATFORM_DIRS = $(wildcard $(DIRS))

# Run all test directories in sequence
.PHONY: test
test:
@for dir in $(PLATFORM_DIRS); do \
@for dir in $(DIRS); do \
$(MAKE) "$$dir" || exit 1; \
done;

# Pattern to execute a single test suite directory
.PHONY: $(PLATFORM_DIRS)
$(PLATFORM_DIRS):
.PHONY: $(DIRS)
$(DIRS):
@echo "Running $@..." ;
$(MAKE) -C "$@" test || exit 1;

Expand All @@ -42,7 +37,7 @@ test-parallel:
--linebuffer \
--jobs $(JOBS) \
$(MAKE) "{}" \
::: $(PLATFORM_DIRS)
::: $(DIRS)


.PHONY: clean
Expand Down