[SV-COMP'18 18/19] Fixing issue 'implicit conversion not permitted' for alias variables. #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several SV-COMP benchmarks where is used and alias variable with a global array variable. The alias varialbe is not array ariable and it wants to alias with the array, i.e. with the first element in the array. This commit prevents the type mismatch.
smowton
reviewed
Apr 9, 2018
| @@ -456,6 +456,23 @@ void c_typecastt::implicit_typecast( | |||
| implicit_typecast_followed(expr, src_type, type_qual, dest_type); | |||
| } | |||
|
|
|||
| static bool is_array_element_alias(const namespacet& ns, const symbolt* const orig_symbol, const typet &src_type, const typet &dest_type) | |||
There was a problem hiding this comment.
Given the type comparison, you're only looking for strict aliases, right? If so suggest renaming function to reflect that.
|
It may be the case that #2106 is a proper fix here. |
|
Closing since this may have been fixed in PR #2106 and no regression tests provided here (blocker even in initial comment). If you believe this closure is erroneous please reopen this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several SV-COMP benchmarks where is used and alias
variable with a global array variable. The alias varialbe is not
array ariable and it wants to alias with the array, i.e. with the
first element in the array. This commit prevents the type mismatch.
Do not merge: regression test required