Migrate all uses of message_streamt to messaget #166
Conversation
tautschnig
force-pushed
the
messaget
branch
3 times, most recently
from
c87d69d to
4f44935
Compare
|
A large fraction of this is now merged -- may I ask for a rebase? |
|
The requested rebase is now done; cherry-picking patches from this pull request instead of manual merges would help a lot to avoid having to spend a lot of time on fixing ensuing conflicts. |
|
Did cherry-pick for most of these! |
|
@tautschnig @kroening What is the status of this, is it still relevant? If yes, should it be rebased, reviewed and merged? Most of the changes seem non-controversial. |
|
Working on the rebase. |
|
I have opened #563 for the linter failure. I'll now look into the regression test failures. |
tautschnig
force-pushed
the
messaget
branch
5 times, most recently
from
6a025cd to
0b05d3c
Compare
|
Has the Travis configuration been removed? The other checks appear to be passing. |
|
No idea why Travis was not showing up, it was running. The tests pass, so I think this should be good to go. @kroening, your turn. |
|
@kroening Could this please be considered for the upcoming release? It will (among lots of other cleanup) get the goto-cc output back to a sane state. |
|
I have cherry-picked the obvious bits. What's the idea of using those counters? |
|
I have rebased the patch set to current master; the message counters allow selective treatment of warnings as errors (just like compilers can be told to do). |
tautschnig
force-pushed
the
messaget
branch
2 times, most recently
from
10ea7c6 to
3ad2675
Compare
|
I have now also added that patch that makes use of message counters (to support -Werror and its equivalents). |
|
@tautschnig this now needs a rebase due to an earlier error in master that got propagated to this branch. |
|
Rebase done. |
|
It should be noted that 51a1b1b handles Wno-error together with Werror for GCC, but does not necessarily cope with conflicting error-configuration parameters for other platforms as I don't have access to those. |
tautschnig
force-pushed
the
messaget
branch
2 times, most recently
from
da2ac8e to
1aaffe3
Compare
Works at all message levels, instead of the previous get_errors_found workarounds.
…re set For goto-cl, goto-armcc, etc the equivalent options enable fail-on-warnings mode. Do not fail with -Werror -Wall (but not -Wextra) as that breaks too many builds as we don't have an equivalent of -Wno-...
GOTO conversion must honour the message handler set up by the chosen goto-cc mode. Thus the message handler set up in the specific mode has to be handed on to compilet. As a language_uit this requires a ui_message_handlert. Consequently make console_message_handlert, gcc_message_handlert ui_message_handlert in PLAIN ui mode (which is consistent).
…_changes [TYT-5] Address Martin's comments of the Cyclic Dependency Analysis
Includes cleanup of messaging APIs and diagnostic output.