Skip to content

Fix iterator comparison bug in expr_iterator #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix iterator comparison bug in expr_iterator #1610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/util/expr_iterator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ struct depth_iterator_expr_statet final
inline bool operator==(
const depth_iterator_expr_statet &left,
const depth_iterator_expr_statet &right)
{ return left.it==right.it && left.expr.get()==right.expr.get(); }
{
return distance(left.it, left.end) == distance(right.it, right.end) &&
left.expr.get() == right.expr.get();
}

/// Depth first search iterator base - iterates over supplied expression
/// and all its operands recursively.
Expand Down