Add message for unknown cbmc option #1058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
See #910 for comments. |
allredj
force-pushed
the
cmdline-feedback-master
branch
3 times, most recently
from
b85055e to
7035ea1
Compare
Contributor
Author
|
@peterschrammel @tautschnig this is ready for your review. |
peterschrammel
approved these changes
Jun 26, 2017
tautschnig
reviewed
Jun 28, 2017
Contributor
Author
|
@tautschnig Yes both PRs are identical and all your comments have been addressed. |
tautschnig
approved these changes
Jul 3, 2017
Collaborator
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
Thanks a lot for the info!
Contributor
Author
|
I think this has already been included into master (via a prior merge I guess). Rebasing the PR on develop resulted in noop. Is it OK to drop this PR @tautschnig? |
tautschnig
changed the title
Collaborator
|
Re-targeted to master. |
During command line parsing, if an unknown option is read, store it and output an error message at parse_options_baset::main Add regression tests to check the feature.
allredj
force-pushed
the
cmdline-feedback-master
branch
from
7035ea1 to
7332fb8
Compare
tautschnig
changed the title
Contributor
Author
|
@peterschrammel Can I close this? It's been in test-generator for a year now and it seems to have been integrated into jbmc in the meantime: |
Member
|
If it is already in |
Contributor
Author
|
Verified already in cbmc/develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During command line parsing, if an unknown option is read, store it and output an error message at
parse_options_baset::main.This adds a message when the command line parser finds an unknown option. Ideally, this should be done using the
messagetframework, butparse_options_basetdoes not inherit from it. All messages produced in this context are directly sent to the standard (as for the help string) or the error outputs.