Skip to content

Fix sipush return type annotation #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Jun 19, 2017

(Source: https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-6.html)

Nothing appears to use the annotation at the moment, so it cause any ill behaviour and can't be tested, but in case it becomes used in the future we might as well correct it.

Also corrected the Wikipedia page where the mistake originated ;)

(Source: https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-6.html)

Nothing appears to use the annotation at the moment, so it cause any ill
behaviour and can't be tested, but in case it becomes used in the future
we might as well correct it.
@smowton smowton requested a review from tautschnig June 19, 2017 12:14
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems thus code ought to be using this annotation... But otherwise that's ok for the moment, I'd say.

@kroening
Copy link
Member

Should be used as the lesson why not to trust Wikipedia

@kroening kroening merged commit dd8ed06 into master Jun 19, 2017
@tautschnig tautschnig deleted the smowton/fix/sipush_return_type branch June 19, 2017 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants