Function Pointer Removal uses a redundant set

[nmanthey]

Dear CBMC team,

I just looked into the function pointer removal code to implement a related functionality. While reading, I spotted a redundancy in the code. The marked line shows that a set "functions" and a set "done" is created, which are both filled at the same time. For checking whether the function is "done", the done set is used, while the functions set is finally returned.

I think one of the two sets can be removed, reducing run time as well as memory consumption.

cbmc/src/goto-programs/compute_called_functions.cpp

Line 83 in b0cb1ee

std::set<irep_idt> done;

Best,
Norbert

[martin-cs]

Thanks for this; I'll see what can be done.