Skip to content

Don't require apiVersion/type for PersistentVolumeClaim #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 3 commits into from
Sep 2, 2020
Merged

Don't require apiVersion/type for PersistentVolumeClaim #2019

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5bf99d
Don't require `apiVersion`/`type` for `PersistentVolumeClaim`
Gabriella439 Sep 2, 2020
b906cef
Merge branch 'master' into gabriel/PersistentVolumeClaim
mergify[bot] Sep 2, 2020
954383a
Merge branch 'master' into gabriel/PersistentVolumeClaim
mergify[bot] Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions dhall-openapi/src/Dhall/Kubernetes/Convert.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,14 @@ requiredFields maybeName required
-- in the Swagger spec but just in the docs
notRequiredConstraints = Data.Map.fromList
[ ( ModelName "io.k8s.api.core.v1.ObjectFieldSelector"
, Set.fromList [FieldName "apiVersion"])
, Set.fromList [ FieldName "apiVersion" ]
)
, ( ModelName "io.k8s.apimachinery.pkg.apis.meta.v1.StatusDetails"
, Set.fromList [FieldName "kind"])
, Set.fromList [ FieldName "kind" ]
)
, ( ModelName "io.k8s.api.core.v1.PersistentVolumeClaim"
, Set.fromList [ FieldName "apiVersion", FieldName "kind" ]
)
]


Expand Down