Tests cannot be ran without an active network connection

[ocharles]

For example, when trying to install Dhall with the Nix sandbox enabled:

      ./dhall-lang/tests/import/success/headerForwardingA.dhall:                                FAIL
        Exception: 
        ↳ https://test.dhall-lang.org/Bool/package.dhall using [ { mapKey = "Test", mapValue = "Example" } ]
        
        Error: Remote host not found
        
        
        15│ https://test.dhall-lang.org/Bool/package.dhall
        16│   using [ { mapKey = "Test", mapValue = "Example" } ]
        
        15:1

I suggest we spin up a local HTTP server for these tests.

[Gabriella439]

@ocharles: How would we get the tests to use to that server?

[ocharles]

One option is to rewrite all the tests to access localhost instead and document how test harnesses should setup a local server.

[Gabriella439]

@ocharles: The main issue is that this greatly increases the test burden of implementation authors, especially the parts of the test that require CORS support or two domains, one of which is protected by authenticated headers

[ocharles]

I suppose the other option is that dhall-haskell could be more configurable in terms of how it does HTTP, and we could just mock the responses out rather than even bothering with a server. Then when we run tests, we can implement a pure approach

[ocharles]

Thanks for the response. I think there may be a solution here to fix this, but we don't need to keep the issue around. But if someone wants to propose a fix in a PR (e.g., me) - great!

[ocharles]

Also, it looks like #1159 should have fixed this anyway, if I understand correctly.

[EggBaconAndSpam]

Also, it looks like #1159 should have fixed this anyway, if I understand correctly.

Yes! I forgot to mention that here...

[Anton-Latukha]

I would bump this. I proposed a suggestion #1837, which is on the topic.