Use vi.stubGlobal for requestAnimationFrame #6393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #3483 we stubbed
requestAnimationFrame
to work around testing-library/svelte-testing-library#206In #4695 we changed from
vi.stubGlobal
toObject.defineProperty
becausevi.unstubAllGlobals
was undoing the workaround.With Vitest 3, using
Object.defineProperty
to redefinerequestAnimationFrame
causesInstead we should go back to
vi.stubGlobal
but use it inbeforeEach
aftervi.unstubAllGlobals
so it's re-stubbed each time.Changes
vi.stubGlobal
forrequestAnimationFrame
instead ofObject.defineProperty
and wrap it inbeforeEach
.Tests
vitest
updated to 3.0.5.Todos
not necessary