Move rate limiting proxy away from shared #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjazerzen
requested review from
a team,
gasperzgonec,
patricijabrecko and
radovanjorgic
as code owners
gasperzgonec
approved these changes
Oct 14, 2025
patricijabrecko
pushed a commit
to devrev/airdrop-trello-snap-in
that referenced
this pull request
Nov 3, 2025
Closed #18 and opened this one for clear diff. ## Summary Related PR: devrev/airdrop-shared#31 After discussion with Gasper and Patricija, we're moving this away from shared and into 3rd party service-specific snap-in repos. Why: In order for the "rate limiting reponse" to match the actual response, rate limiting proxy has to be very slightly adopted for each 3rd party service provider (I indicated and documented what has to be changed). - [#ISS-217157](https://app.devrev.ai/devrev/works/ISS-217157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review #27, #29, #30 first.
Summary
A small detail of the rate limiting proxy had to be adopted for every 3rd party service provider.
After discussion with Gasper and Patricija, we're moving this away from shared and into 3rd party service-specific snap-in repos.