Skip to content

Conversation

edupr91
Copy link
Contributor

@edupr91 edupr91 commented Aug 3, 2025

Adding a new event in Barcelona for 2026

Changes in this PR:

  • BCN-2026: Add welcome, contact and conduct pages
  • BCN-2026: Add assets and initial logo.

@edupr91 edupr91 requested a review from a team as a code owner August 3, 2025 07:36
Copy link

netlify bot commented Aug 3, 2025

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 80d8767
🔍 Latest deploy log https://app.netlify.com/projects/devopsdays-web/deploys/6894249ef7e787000842d6ed
😎 Deploy Preview https://deploy-preview-15384--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nimbinatus
Copy link
Member

nimbinatus commented Aug 4, 2025

Hi there! I'm noticing some file updates missing from this PR. Did you use the new event script? More information here: https://github.com/devopsdays/devopsdays-web/tree/main/utilities#events

We really recommend using that script to set up a new event as it ensures that all of the files you need to update and set up are present, and you don't need to keep up to date on changes we've made to the build system.

GitHub
This is the website for devopsdays. Contribute to devopsdays/devopsdays-web development by creating an account on GitHub.

Copy link
Contributor

@toshywoshy toshywoshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a change to the redirect, I suggest you do add this static/_redirects
/barcelona/* /events/2013-barcelona/:splat 302
Would need to change to
/barcelona/* /events/2026-barcelona/:splat 302

</p>
</td>
<td width="40%" valign="top" align="center">
<img alt="DevOpsDays Barcelona 2026" src="/events/2026-barcelona/logo.png" width="300" height="450" border="0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use {{< event_logo >}} this allows you to remove the static image file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✔️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not required anymore, please remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File has been deleted

# variable: 2019-01-05T23:59:59+02:00
# Note: we allow 2026-MM-DD for backward compatibility, but it can lead to unexpected behaviors (like your event disappearing from the front page during your last day)

startdate: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: Since these dates aren't populated, you won't see your logo on the main page. Don't panic! You can find your event listed in the left sidebar under "TBD". Once you have a date here, your logo will appear with the others on the main page :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. i noticed that while changing the main file 😃
Thanks for the note 👌

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You won't need this one moving forward as the build now pulls from the assets/events/2026-barcelona/logo.png instead :)

If you want to use the logo in your welcome page and it's not loading without this file, use the shortcode {{< event_logo >}} instead of trying to use HTML (more info in the theme docs).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✔️

@nimbinatus
Copy link
Member

Ha, sorry for the double review! @toshywoshy and I must be reviewing at the same time :)

@edupr91
Copy link
Contributor Author

edupr91 commented Aug 4, 2025

eughh yeah I did not see the utilities folder ^^'
Between today and tomorrow morning, I will review the changes.

Sorry for the trouble :-)

Copy link
Contributor

@toshywoshy toshywoshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the CITY and YYYY to your city name and year

@@ -0,0 +1,87 @@
+++
Title = "devopsdays CITY YYYY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this, to use your city and year

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✔️

+++
Title = "devopsdays CITY YYYY"
Type = "welcome"
aliases = ["/events/yyyy-city/"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again here year-city, so the slug gets created properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✔️

Title = "devopsdays CITY YYYY"
Type = "welcome"
aliases = ["/events/yyyy-city/"]
Description = "devopsdays CITY YYYY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here again add your city and year

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✔️

+++
Title = "Contact"
Type = "event"
Description = "Contact information for devopsdays CITY YYYY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again here chnge the city and the year

+++
Title = "Location"
Type = "event"
Description = "Location for devopsdays CITY YYYY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again here chnge the city and the year

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✔️

+++
Title = "Propose"
Type = "event"
Description = "Propose a talk for devopsdays CITY YYYY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again here chnge the city and the year

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✔️

+++
Title = "Registration"
Type = "event"
Description = "Registration for devopsdays CITY YYYY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However this file is not used at present, to avoid to remember it later, please change the city and the year

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✔️

@edupr91
Copy link
Contributor Author

edupr91 commented Aug 7, 2025

Thanks for the notes. I understood the files under yyyy-city as templates for pages, but yeah, now I see the point of updating the files to avoid future trouble.
Thanks again 😃

@phrawzty
Copy link
Collaborator

Hello @edupr91 @nimbinatus and @toshywoshy.

What's up with the /yyyy-city/ subdirectory? It's not at all standard.

@edupr91 Did you use the create_new_event.sh script when creating this event? If not, why not? If yes, why did you change the output afterwards?

Can somebody please explain using clear and exact language what the purpose of this organisational structure us? What is the goal of this structure? What problem does it solve? Why is this event being implemented differently than literally every other event?

Thank you.

@toshywoshy
Copy link
Contributor

Well, my point was that the slug entry in the file on that line needs to be changed, not the directory.
Hugo will build the markdown files, the front matter currenty has yyyy-city in place of 2025-barcelona, so Hugo will build this with the current generic alias in place of the correct year-city alias as we want.
I see that @edupr91 move these files in place of changing the entry on those lines I indicated to be correct.

@edupr91
Copy link
Contributor Author

edupr91 commented Aug 18, 2025

Hello @phrawzty,

Thank you for your questions. I've reviewed my steps and can now provide clarity on the recent changes.

Addressing the Questions

  • Did you use the create_new_event.sh script? No, I did not.

  • Why not? When I began my work, I used the instructions in the CONTRIBUTING.md file. I wasn't aware of the utility scripts until @nimbinatus and @toshywoshy pointed them out.

  • What's up with the /yyyy-city/ subdirectory, and why did you change the output? After discovering the script, I used it to comply with the standard format. However, when I ran the script for an event that already had a directory, it created a new subdirectory named /yyyy-city/ within it. I didn't initially recognise this as an issue and proceeded with the changes, which is what led to the non-standard output.

I apologise for the misunderstanding on my part.

Moving Forward

To resolve this, I propose closing this pull request and creating a new one from scratch, using only the create_new_event.sh script. This will ensure all changes are clean and follow the expected standards.

Additionally, I would like to suggest two improvements to prevent this from happening in the future:

  1. Add a line about the utility scripts to the CONTRIBUTING.md file to make them more discoverable for new contributors.

  2. Add a check to the create_new_event.sh script to validate whether an event's folder already exists. If it does, the script should exit with a clear error message instead of creating a new subdirectory.

Please let me know if these changes sound good. I can create the related issues if you agree.

@FloorD
Copy link
Contributor

FloorD commented Aug 22, 2025

Hello @phrawzty,

Thank you for your questions. I've reviewed my steps and can now provide clarity on the recent changes.

Addressing the Questions

  • Did you use the create_new_event.sh script? No, I did not.
  • Why not? When I began my work, I used the instructions in the CONTRIBUTING.md file. I wasn't aware of the utility scripts until @nimbinatus and @toshywoshy pointed them out.
  • What's up with the /yyyy-city/ subdirectory, and why did you change the output? After discovering the script, I used it to comply with the standard format. However, when I ran the script for an event that already had a directory, it created a new subdirectory named /yyyy-city/ within it. I didn't initially recognise this as an issue and proceeded with the changes, which is what led to the non-standard output.

I apologise for the misunderstanding on my part.

Moving Forward

To resolve this, I propose closing this pull request and creating a new one from scratch, using only the create_new_event.sh script. This will ensure all changes are clean and follow the expected standards.

Additionally, I would like to suggest two improvements to prevent this from happening in the future:

  1. Add a line about the utility scripts to the CONTRIBUTING.md file to make them more discoverable for new contributors.
  2. Add a check to the create_new_event.sh script to validate whether an event's folder already exists. If it does, the script should exit with a clear error message instead of creating a new subdirectory.

Please let me know if these changes sound good. I can create the related issues if you agree.

@toshywoshy wdyt about David's proposal? I've updated the member list for barcelona@

@edupr91
Copy link
Contributor Author

edupr91 commented Aug 25, 2025

New PR created. #15442

@toshywoshy
Copy link
Contributor

Sorry, did not see the updates here
Yes, we need better scripts or other ways to create a new event, updating and maintaining event details.
These scripts should validate things already so it makes it easier for reviewers to approve.
As for suggestion to add this to the CONTRIBUTING.md, I think we haven't done so as we never really got enough feedback if the scripts work for more then "It runs on my laptop", so we need more people using and providing feedback

@nimbinatus
Copy link
Member

I've merged the other PR, and I've opened a new issue at #15457. Let's move the general conversation about the utilities script there. Sorry for all of the confusion, folks!

@nimbinatus nimbinatus closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants