Feat: 운영서버 CI/CD 구축 #17

guite95 · 2026-01-19T11:08:58Z

📋 상세 설명

운영서버 CI/CD 구축
소셜로그인 관련 로직 수정
불필요한 주석 삭제

📊 체크리스트

PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
코드가 테스트 되었나요
문서는 업데이트 되었나요
불필요한 코드를 제거했나요
이슈와 라벨이 등록되었나요

📆 마감일

Close #{issue number}

…into fix-api-deploy # Conflicts: # .github/workflows/deploy.yml

Copilot

Pull request overview

This PR implements CI/CD for the production server deployment, refactors the social login flow to use redirects instead of JSON responses, and removes unnecessary code comments throughout the codebase.

Changes:

Adds GitHub Actions workflow for production deployment using GHCR and on-premise server
Modifies OAuth2 success handler to redirect to frontend with URL-encoded data instead of returning JSON responses
Updates social signup flow to automatically generate and set JWT tokens in cookies upon completion
Removes old AWS ECR-based CI/CD workflow and replaces with GHCR-based deployment

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 16 comments.

Show a summary per file

File	Description
.github/workflows/deploy-prod.yml	New CI/CD workflow for production deployment using GitHub Container Registry and on-premise infrastructure
.github/workflows/deploy.yml	Removed old AWS ECR-based deployment workflow
docker-compose-auth-prod.yml	Docker Compose configuration for production auth server deployment
src/main/resources/application-sample.yml	Updated database host, Kafka, S3 endpoint configurations, and JWT token validity settings with mail server configuration
src/main/java/until/the/eternity/das/oauth/handler/OAuth2SuccessHandler.java	Refactored to redirect to frontend with URL-encoded data instead of JSON responses
src/main/java/until/the/eternity/das/oauth/service/SocialAuthService.java	Added jwtForSocialSignUp method to generate tokens and update login timestamp
src/main/java/until/the/eternity/das/auth/presentation/AuthController.java	Modified completeSocialSignup to generate and set JWT cookies automatically
src/main/java/until/the/eternity/das/user/dto/response/UserInfoResponse.java	Added email field to user info response
src/main/java/until/the/eternity/das/common/application/S3Service.java	Improved deleteImage method with better URI parsing
src/main/java/until/the/eternity/das/DasApplication.java	Added timezone configuration to Asia/Seoul
Multiple files	Removed unnecessary comments throughout codebase

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-19T12:45:29Z

src/main/java/until/the/eternity/das/oauth/handler/OAuth2SuccessHandler.java

+    Map<String, Object> signupData = Map.of(
+      "provider", oauthUserDTO.getProvider(),
+      "providerUserId", oauthUserDTO.getProviderUserId(),
+      "email", oauthUserDTO.getEmail() != null ? oauthUserDTO.getEmail() : ""


When oauthUserDTO.getEmail() is null, the code uses an empty string as the default value. However, this could lead to issues if the frontend or other components expect either a valid email or null, not an empty string. Consider using null instead of an empty string for consistency, or document why an empty string is the preferred default.

Copilot · 2026-01-19T12:45:29Z

src/main/java/until/the/eternity/das/auth/application/AuthConverter.java

+  /**
+   * 소셜 회원가입 유저 저장 관련
+   *
+   * @param oauthUserDTO
+   * @param nickname
+   * @param role
+   * @param profileImageUrl
+   * @return
+   */


The Javadoc comment is incomplete with parameter descriptions missing. Either complete the documentation with proper parameter descriptions and return value explanation, or remove the incomplete @param and @return tags.

Copilot · 2026-01-19T12:45:29Z

src/main/java/until/the/eternity/das/oauth/service/SocialAuthService.java

+  public LoginResultResponse jwtForSocialSignUp(Long userId) {
+    User user = userRepository.findById(userId)
+      .orElseThrow(() -> new CustomException(GlobalExceptionCode.USER_NOT_EXISTS));
+
+    user.updateLastLoginAt();
+
+    String accessToken = jwtUtil.generateAccessToken(user);
+    String refreshToken = jwtUtil.generateRefreshToken(user);
+
+    tokenService.saveNewRefreshToken(user.getId(), refreshToken);
+
+    return LoginResultResponse.builder()
+      .user(user)
+      .accessToken(accessToken)
+      .refreshToken(refreshToken)
+      .build();
+  }


The new method jwtForSocialSignUp lacks test coverage. Since the repository includes tests for other service methods, this new method should also have corresponding unit tests to verify the JWT generation, token saving, and last login update behavior.

Copilot · 2026-01-19T12:45:30Z

.github/workflows/deploy-prod.yml

+            docker compose -f docker-compose-auth-prod.yml --env-file .env.auth pull
+            docker compose -f docker-compose-auth-prod.yml --env-file .env.auth up -d


The docker compose command uses 'docker compose' (with a space) which is the Docker Compose V2 syntax. Ensure that the target production server has Docker Compose V2 installed. If it only has V1, this command will fail as it expects 'docker-compose' (with a hyphen).

Suggested change

docker compose -f docker-compose-auth-prod.yml --env-file .env.auth pull

docker compose -f docker-compose-auth-prod.yml --env-file .env.auth up -d

docker-compose -f docker-compose-auth-prod.yml --env-file .env.auth pull

docker-compose -f docker-compose-auth-prod.yml --env-file .env.auth up -d

Copilot · 2026-01-19T12:45:30Z

src/main/resources/application-sample.yml

+    host: smtp.gmail.com
+    port: 587
+    username: ${MAIL_USERNAME:[email protected]}
+    password: ${MAIL_PASSWORD:ipghhpopgxncgzgg}


The default password value appears to be a real credential. Even in a sample configuration file, exposing what looks like an actual app password is a security risk. This should be replaced with a placeholder value like 'your-app-password-here'.

Suggested change

password: ${MAIL_PASSWORD:ipghhpopgxncgzgg}

password: ${MAIL_PASSWORD:your-mail-password-here}

Copilot · 2026-01-19T12:45:32Z

docker-compose-auth-prod.yml

+      - .env.auth
+    environment:
+      - JAVA_OPTS=-Xms256m -Xmx512m
+      - SPRING_CLOUD_AWS_S3_ENDPOINT=${MINIO_ENDPOINT}


The SPRING_CLOUD_AWS_S3_ENDPOINT environment variable is set but doesn't match the s3.endpoint configuration pattern in application-sample.yml (which uses OCI_NAMESPACE). Ensure that the .env.auth file contains the properly formatted endpoint URL or that this environment variable correctly overrides the application configuration.

Suggested change

- SPRING_CLOUD_AWS_S3_ENDPOINT=${MINIO_ENDPOINT}

- SPRING_CLOUD_AWS_S3_ENDPOINT=https://objectstorage.${OCI_NAMESPACE}.oraclecloud.com

Copilot · 2026-01-19T12:45:32Z

src/main/java/until/the/eternity/das/oauth/service/SocialAuthService.java

+    User user = userRepository.findById(userId)
+      .orElseThrow(() -> new CustomException(GlobalExceptionCode.USER_NOT_EXISTS));
+
+    user.updateLastLoginAt();


The method jwtForSocialSignUp calls user.updateLastLoginAt() but the user object is not explicitly saved to the database. While the @transactional annotation should handle this, it's worth verifying that the change is persisted. If updateLastLoginAt() doesn't mark the entity as dirty, the change might not be saved.

Suggested change

user.updateLastLoginAt();

user.updateLastLoginAt();

userRepository.save(user);

Copilot · 2026-01-19T12:45:33Z

src/main/java/until/the/eternity/das/DasApplication.java

-	}
+  @PostConstruct
+  public void started() {
+    TimeZone.setDefault(TimeZone.getTimeZone("Asia/Seoul"));


Hardcoding the timezone in the application may cause issues for users in different timezones or deployments in different regions. Consider making the timezone configurable through environment variables to allow flexibility across different deployment environments.

Copilot · 2026-01-19T12:45:33Z

src/main/java/until/the/eternity/das/oauth/handler/OAuth2SuccessHandler.java

+    redirectWithData(response, code, message, Map.of(
+      "userId", user.getId(),
+      "nickname", user.getNickname(),
+      "email", user.getEmail()


Setting cookies in the response and then redirecting to a different domain may cause the cookies to be lost, depending on browser SameSite policies and CORS configuration. The cookies are set with response at lines 106-107, but then a redirect is performed at line 98/73. If the frontend is on a different domain, these cookies might not be properly sent. Consider reviewing the cookie SameSite and Secure attributes configuration, or consider passing tokens through the redirect URL instead (with appropriate security measures).

Suggested change

"email", user.getEmail()

"email", user.getEmail(),

"accessToken", accessToken,

"refreshToken", refreshToken

Copilot · 2026-01-19T12:45:33Z

src/main/java/until/the/eternity/das/oauth/handler/OAuth2SuccessHandler.java

+            GlobalExceptionCode.SERVER_ERROR))
+          .getProvider();
+
+        String errorMsg = "이미 다른 계정으로 가입된 이메일입니다. \n 가입된 이메일 : " + provider;


The error message at line 70 contains a newline character '\n' which may not render properly in all contexts (browser alerts, JSON, etc.). Consider using a more appropriate message format or replacing '\n' with an HTML line break or space depending on how the frontend displays this message.

Suggested change

String errorMsg = "이미 다른 계정으로 가입된 이메일입니다. \n 가입된 이메일 : " + provider;

String errorMsg = "이미 다른 계정으로 가입된 이메일입니다. 가입된 이메일 : " + provider;

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 18 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-29T15:12:09Z

src/main/java/until/the/eternity/das/auth/application/AuthConverter.java

+  /**
+   * 소셜 회원가입 유저 저장 관련
+   *
+   * @param oauthUserDTO
+   * @param nickname
+   * @param role
+   * @param profileImageUrl
+   * @return
+   */


The PR description mentions "불필요한 주석 삭제" (removing unnecessary comments) but the AuthConverter.java file shows new Javadoc comments being added, not removed. While these are proper documentation additions, they contradict the stated goal of removing unnecessary comments. The Javadoc comments added here are incomplete - they list parameters without descriptions, which violates standard Javadoc conventions and may not provide useful documentation.

Copilot · 2026-01-29T15:12:09Z

.github/workflows/deploy-prod.yml

+    paths:
+      - 'src/**'
+      - 'docker-compose-auth-prod.yml'
+      - '.github/workflows/deploy-prod.yml'


The workflow file paths trigger includes the workflow file itself (line 9), which means any change to this workflow file will trigger a deployment. This could lead to unnecessary deployments when only CI/CD configuration changes are made without any application code changes. Consider removing '.github/workflows/deploy-prod.yml' from the paths trigger unless deployment configuration changes should always trigger a deployment.

Copilot · 2026-01-29T15:12:10Z

src/main/java/until/the/eternity/das/user/dto/response/UserInfoResponse.java

 import java.time.LocalDateTime;

 public record UserInfoResponse(
+  String email,


Adding the email field as the first parameter in the UserInfoResponse record is a breaking API change. Since this is a record, the order of fields matters for serialization and any existing consumers of this API will receive data in a different order. JSON clients relying on positional parsing or specific field ordering could break. While named JSON fields should work fine, this changes the API contract. Consider documenting this as a breaking change or using a different approach (like versioning the API or making it an optional addition).

Copilot · 2026-01-29T15:12:10Z

src/main/java/until/the/eternity/das/oauth/handler/OAuth2SuccessHandler.java

+        String provider = oauthUserRepository.findByUser(userOpt.get())
+          .orElseThrow(() -> new CustomException(
+            GlobalExceptionCode.SERVER_ERROR))
+          .getProvider();
+
+        String errorMsg = "이미 다른 계정으로 가입된 이메일입니다. \n 가입된 이메일 : " + provider;


The error message logic is incorrect. When a user with email exists and is found via a social provider, the message says "이미 다른 계정으로 가입된 이메일입니다" (already registered with a different account). However, this is misleading because the code found the user by their email, meaning they're trying to login with the SAME provider's email. The message should clarify whether this is the same provider or a different one. The current logic will show this error even if the user is trying to login with the correct provider but hasn't completed registration yet.

Suggested change

String provider = oauthUserRepository.findByUser(userOpt.get())

.orElseThrow(() -> new CustomException(

GlobalExceptionCode.SERVER_ERROR))

.getProvider();

String errorMsg = "이미 다른 계정으로 가입된 이메일입니다. \n 가입된 이메일 : " + provider;

String existingProvider = oauthUserRepository.findByUser(userOpt.get())

.orElseThrow(() -> new CustomException(

GlobalExceptionCode.SERVER_ERROR))

.getProvider();

String currentProvider = oauthUserDTO.getProvider();

String errorMsg;

if (existingProvider != null && currentProvider != null

&& existingProvider.equalsIgnoreCase(currentProvider)) {

errorMsg = "이미 해당 소셜 계정으로 가입된 이메일입니다.\\n소셜 제공자: " + existingProvider;

} else {

errorMsg = "이미 다른 소셜 계정으로 가입된 이메일입니다.\\n가입된 소셜 제공자: " + existingProvider;

}

Copilot · 2026-01-29T15:12:10Z

src/main/resources/application-sample.yml

    locations: classpath:db/migration
  kafka:
-    bootstrap-servers: localhost:9092
+    bootstrap-servers: ${KAFKA_BOOTSTRAP_SERVERS}


The kafka bootstrap-servers configuration has changed from a hardcoded localhost:9092 to an environment variable without a default value. This will cause the application to fail at startup if KAFKA_BOOTSTRAP_SERVERS is not set. Consider providing a default value like ${KAFKA_BOOTSTRAP_SERVERS:localhost:9092} to support local development.

Copilot · 2026-01-29T15:12:13Z

src/main/resources/application-sample.yml

+  issuer: devnogi
+  access-token-cookie-name: access_token
+  refresh-token-cookie-name: refresh_token


The JWT configuration values for issuer, access-token-cookie-name, and refresh-token-cookie-name have been changed from environment variables with defaults to hardcoded values. This reduces flexibility for different deployment environments. These were previously configurable via JWT_ISSUER, JWT_ACCESS_TOKEN_COOKIE_NAME, and JWT_REFRESH_TOKEN_COOKIE_NAME environment variables, which is a better practice for different environments (dev, staging, prod).

Copilot · 2026-01-29T15:12:13Z

src/main/resources/application-sample.yml

      credentials:
        access-key: ${AWS_ACCESS_KEY}
        secret-key: ${AWS_SECRET_KEY}
+      s3:


The S3 configuration now includes OCI-specific settings (OCI_NAMESPACE), suggesting a migration from AWS S3 to Oracle Cloud Infrastructure Object Storage. However, the bucket environment variable is still named S3_BUCKET and there's no indication of this architectural change in the PR description. This could lead to confusion about which cloud provider is being used.

Suggested change

s3:

s3:

# NOTE: Although this configuration is under `spring.cloud.aws.s3`,

# it is intentionally pointing to Oracle Cloud Infrastructure (OCI)

# Object Storage via its S3-compatible endpoint.

# Spring Cloud AWS is used here purely as an S3-compatible client,

# and the AWS-style property names are kept for backwards compatibility.

Copilot · 2026-01-29T15:12:13Z

src/main/java/until/the/eternity/das/DasApplication.java

+  @PostConstruct
+  public void started() {
+    TimeZone.setDefault(TimeZone.getTimeZone("Asia/Seoul"));


The TimeZone.setDefault call in a @PostConstruct method affects the entire JVM's default timezone. This is a global side effect that could impact other components or libraries that rely on the system default timezone. While this might be intentional for ensuring consistent timezone handling, it's generally better to configure timezone explicitly in application properties (spring.jpa.properties.hibernate.jdbc.time_zone) or use zone-aware date/time types (ZonedDateTime) rather than changing JVM-wide settings.

Copilot · 2026-01-29T15:12:14Z

src/main/java/until/the/eternity/das/DasApplication.java


+import java.util.TimeZone;
+
+@EnableAsync


The @EnableAsync annotation has been added to the main application class, but there's no corresponding async functionality added in this PR's changes. If async processing is being added, there should be corresponding @async annotated methods or configuration for thread pool settings (executor configuration). Without proper configuration, Spring will use the default SimpleAsyncTaskExecutor which creates a new thread for each task, which is not suitable for production use.

Copilot · 2026-01-29T15:12:14Z

src/main/resources/application-sample.yml

  datasource:
    driver-class-name: com.mysql.cj.jdbc.Driver
-    url: jdbc:mysql://localhost:${DB_PORT}/${DB_SCHEMA}
+    url: jdbc:mysql://${DB_HOST}:${DB_PORT}/${DB_SCHEMA}


The database host configuration has changed from localhost to an environment variable, but there's no default value provided. The pattern ${DB_HOST} will cause the application to fail at startup if DB_HOST is not set. Consider providing a default value like ${DB_HOST:localhost} to maintain backward compatibility with local development environments.

guite95 added 7 commits January 19, 2026 18:30

fix: 소셜로그인 관련 로직 수정

d8ccb23

fix: 서버 시간 KST로 설정

8858533

fix: MinIO사용 삭제 로직으로 변경

3e3bcdc

fix: application파일 수정

51ca383

feat: 운영서버 CI/CD 파이프라인

4516025

fix: 불필요한 주석 삭제

27bcc37

Merge branch 'dev' of https://github.com/devnogi/devnogi-auth-server …

450d6d0

…into fix-api-deploy # Conflicts: # .github/workflows/deploy.yml

guite95 added ✨feature 새로운 기능 추가 🔧fix 버그 해결 labels Jan 19, 2026

dev-ant requested a review from Copilot January 19, 2026 12:39

dev-ant assigned guite95 Jan 19, 2026

Copilot started reviewing on behalf of dev-ant January 19, 2026 12:39 View session

Copilot AI reviewed Jan 19, 2026

View reviewed changes

dev-ant requested a review from Copilot January 29, 2026 15:05

Copilot started reviewing on behalf of dev-ant January 29, 2026 15:06 View session

dev-ant approved these changes Jan 29, 2026

View reviewed changes

Copilot AI reviewed Jan 29, 2026

View reviewed changes

fix: 배포 관련 로직 수정

f9c98fe

		docker compose -f docker-compose-auth-prod.yml --env-file .env.auth pull
		docker compose -f docker-compose-auth-prod.yml --env-file .env.auth up -d

	password: ${MAIL_PASSWORD:ipghhpopgxncgzgg}
	password: ${MAIL_PASSWORD:your-mail-password-here}

	- SPRING_CLOUD_AWS_S3_ENDPOINT=${MINIO_ENDPOINT}
	- SPRING_CLOUD_AWS_S3_ENDPOINT=https://objectstorage.${OCI_NAMESPACE}.oraclecloud.com

	user.updateLastLoginAt();
	user.updateLastLoginAt();
	userRepository.save(user);

-      "email", user.getEmail()
+      "email", user.getEmail(),
+      "accessToken", accessToken,
+      "refreshToken", refreshToken

	String errorMsg = "이미 다른 계정으로 가입된 이메일입니다. \n 가입된 이메일 : " + provider;
	String errorMsg = "이미 다른 계정으로 가입된 이메일입니다. 가입된 이메일 : " + provider;

-      s3:
+      s3:
+        # NOTE: Although this configuration is under `spring.cloud.aws.s3`,
+        # it is intentionally pointing to Oracle Cloud Infrastructure (OCI)
+        # Object Storage via its S3-compatible endpoint.
+        # Spring Cloud AWS is used here purely as an S3-compatible client,
+        # and the AWS-style property names are kept for backwards compatibility.

Feat: 운영서버 CI/CD 구축 #17

Are you sure you want to change the base?

Feat: 운영서버 CI/CD 구축 #17

Uh oh!

Conversation

guite95 commented Jan 19, 2026

📋 상세 설명

📊 체크리스트

📆 마감일

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers