Skip to content

Conversation

szechyjs
Copy link

@szechyjs szechyjs commented Mar 30, 2021

Bug fix

Description

Simplecov changed the .last_run.json file.

Fixes #5

Also fixed a spelling typo.

Why should this be added

Without this the action errors:

/action/lib/report_adapter.rb:10:in `conslusion': undefined method `>=' for nil:NilClass (NoMethodError)
	from /action/lib/github_check_run_service.rb:20:in `run'
	from /action/lib/index.rb:29:in `<main>'

Checklist

  • My code follows the style guidelines of this project
  • Actions are passing

Copy link

@ericboehs ericboehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Supports old and new syntax.

@joshmfrankel
Copy link

joshmfrankel commented Feb 18, 2022

This fixes the /action/lib/report_adapter.rb:10:in conslusion': undefined method >=' for nil:NilClass though I'm not seeing the screenshots as part of the Github Action output. Does anyone know if that still works?

Is it perhaps to do with permissions or private repo?

@ericboehs
Copy link

Can this be closed or merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What formatter to use for SimpleCov
3 participants