Skip to content

Make sure project properties initialize after source control #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kzu merged 1 commit into from
Nov 21, 2024
Merged

Make sure project properties initialize after source control #434

kzu merged 1 commit into from
Nov 21, 2024

Conversation

@kzu
Copy link
Member

@kzu kzu commented Nov 21, 2024

If source control information is supported, make sure we automatically take a dependency on InitializeSourceControlInformation.

We take the chance to also rename the old property InjectThisAssemblyProjectDependsOn to PrepareProjectPropertiesDependsOn which aligns better with the new target.

@kzu
Make sure project properties initialize after source control
1aa6339 
If source control information is supported, make sure we automatically take a dependency on InitializeSourceControlInformation.

We take the chance to also rename the old property `InjectThisAssemblyProjectDependsOn` to `PrepareProjectPropertiesDependsOn` which aligns better with the new target.
@kzu kzu added the bug Something isn't working label Nov 21, 2024
@kzu kzu enabled auto-merge (rebase) November 21, 2024 19:16
@devlooped-bot
Copy link
Member

devlooped-bot commented Nov 21, 2024 •
edited
Loading

32 passed 32 passed
32 passed 32 passed
32 passed 32 passed

🧪 Details on macOS Unix 14.7.0

✅ ThisAssemblyTests.ScribanTests.CanRenderModel
✅ ThisAssemblyTests.Tests.CanReadResourceFile
✅ ThisAssemblyTests.Tests.CanUseByteResource
✅ ThisAssemblyTests.Tests.CanUseConstants
✅ ThisAssemblyTests.Tests.CanUseFileConstantInvalidIdentifier
✅ ThisAssemblyTests.Tests.CanUseFileConstantLinkedFile
✅ ThisAssemblyTests.Tests.CanUseFileConstants
✅ ThisAssemblyTests.Tests.CanUseFileInvalidCharacters
✅ ThisAssemblyTests.Tests.CanUseGitBranchConstants
✅ ThisAssemblyTests.Tests.CanUseGitConstants
✅ ThisAssemblyTests.Tests.CanUseHierarchicalMetadata
✅ ThisAssemblyTests.Tests.CanUseInfo
✅ ThisAssemblyTests.Tests.CanUseInfoDescription
✅ ThisAssemblyTests.Tests.CanUseMetadata
✅ ThisAssemblyTests.Tests.CanUseMultilineProjectProperty
✅ ThisAssemblyTests.Tests.CanUseProjectFullFileContents
✅ ThisAssemblyTests.Tests.CanUseProjectProperty
✅ ThisAssemblyTests.Tests.CanUseProjectRepositoryUrl
✅ ThisAssemblyTests.Tests.CanUseSameNameDifferentExtensions
✅ ThisAssemblyTests.Tests.CanUseSemicolonsInConstant
✅ ThisAssemblyTests.Tests.CanUseStringResource
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseTextResource
✅ ThisAssemblyTests.Tests.CanUseTypedBoolConstant
✅ ThisAssemblyTests.Tests.CanUseTypedDoubleConstant
✅ ThisAssemblyTests.Tests.CanUseTypedInt64Constant
✅ ThisAssemblyTests.Tests.CanUseTypedIntConstant
✅ ThisAssemblyTests.Tests.CanUseTypedLongConstant
✅ ThisAssemblyTests.Tests.CanUseTypedTimeSpanStaticProp

🧪 Details on Ubuntu 22.04.5 LTS

✅ ThisAssemblyTests.ScribanTests.CanRenderModel
✅ ThisAssemblyTests.Tests.CanReadResourceFile
✅ ThisAssemblyTests.Tests.CanUseByteResource
✅ ThisAssemblyTests.Tests.CanUseConstants
✅ ThisAssemblyTests.Tests.CanUseFileConstantInvalidIdentifier
✅ ThisAssemblyTests.Tests.CanUseFileConstantLinkedFile
✅ ThisAssemblyTests.Tests.CanUseFileConstants
✅ ThisAssemblyTests.Tests.CanUseFileInvalidCharacters
✅ ThisAssemblyTests.Tests.CanUseGitBranchConstants
✅ ThisAssemblyTests.Tests.CanUseGitConstants
✅ ThisAssemblyTests.Tests.CanUseHierarchicalMetadata
✅ ThisAssemblyTests.Tests.CanUseInfo
✅ ThisAssemblyTests.Tests.CanUseInfoDescription
✅ ThisAssemblyTests.Tests.CanUseMetadata
✅ ThisAssemblyTests.Tests.CanUseMultilineProjectProperty
✅ ThisAssemblyTests.Tests.CanUseProjectFullFileContents
✅ ThisAssemblyTests.Tests.CanUseProjectProperty
✅ ThisAssemblyTests.Tests.CanUseProjectRepositoryUrl
✅ ThisAssemblyTests.Tests.CanUseSameNameDifferentExtensions
✅ ThisAssemblyTests.Tests.CanUseSemicolonsInConstant
✅ ThisAssemblyTests.Tests.CanUseStringResource
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseTextResource
✅ ThisAssemblyTests.Tests.CanUseTypedBoolConstant
✅ ThisAssemblyTests.Tests.CanUseTypedDoubleConstant
✅ ThisAssemblyTests.Tests.CanUseTypedInt64Constant
✅ ThisAssemblyTests.Tests.CanUseTypedIntConstant
✅ ThisAssemblyTests.Tests.CanUseTypedLongConstant
✅ ThisAssemblyTests.Tests.CanUseTypedTimeSpanStaticProp

🧪 Details on Microsoft Windows 10.0.20348

✅ ThisAssemblyTests.ScribanTests.CanRenderModel
✅ ThisAssemblyTests.Tests.CanReadResourceFile
✅ ThisAssemblyTests.Tests.CanUseByteResource
✅ ThisAssemblyTests.Tests.CanUseConstants
✅ ThisAssemblyTests.Tests.CanUseFileConstantInvalidIdentifier
✅ ThisAssemblyTests.Tests.CanUseFileConstantLinkedFile
✅ ThisAssemblyTests.Tests.CanUseFileConstants
✅ ThisAssemblyTests.Tests.CanUseFileInvalidCharacters
✅ ThisAssemblyTests.Tests.CanUseGitBranchConstants
✅ ThisAssemblyTests.Tests.CanUseGitConstants
✅ ThisAssemblyTests.Tests.CanUseHierarchicalMetadata
✅ ThisAssemblyTests.Tests.CanUseInfo
✅ ThisAssemblyTests.Tests.CanUseInfoDescription
✅ ThisAssemblyTests.Tests.CanUseMetadata
✅ ThisAssemblyTests.Tests.CanUseMultilineProjectProperty
✅ ThisAssemblyTests.Tests.CanUseProjectFullFileContents
✅ ThisAssemblyTests.Tests.CanUseProjectProperty
✅ ThisAssemblyTests.Tests.CanUseProjectRepositoryUrl
✅ ThisAssemblyTests.Tests.CanUseSameNameDifferentExtensions
✅ ThisAssemblyTests.Tests.CanUseSemicolonsInConstant
✅ ThisAssemblyTests.Tests.CanUseStringResource
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseTextResource
✅ ThisAssemblyTests.Tests.CanUseTypedBoolConstant
✅ ThisAssemblyTests.Tests.CanUseTypedDoubleConstant
✅ ThisAssemblyTests.Tests.CanUseTypedInt64Constant
✅ ThisAssemblyTests.Tests.CanUseTypedIntConstant
✅ ThisAssemblyTests.Tests.CanUseTypedLongConstant
✅ ThisAssemblyTests.Tests.CanUseTypedTimeSpanStaticProp

from dotnet-retest v0.6.3 on .NET 8.0.10 with 💜

@kzu kzu merged commit ec77de1 into main Nov 21, 2024
10 checks passed
@kzu kzu deleted the dev/sourcecontrol branch November 21, 2024 19:24
@devlooped devlooped locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kzu @devlooped-bot