Skip to content

Conversation

@dillonwelch
Copy link
Contributor

@dillonwelch dillonwelch requested a review from a team October 13, 2018 15:23
@coveralls
Copy link
Collaborator

coveralls commented Oct 13, 2018

Pull Request Test Coverage Report for Build 147

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 88.918%

Files with Coverage Reduction New Missed Lines %
test/test_password_expired_controller.rb 1 100.0%
lib/devise-security/controllers/helpers.rb 1 50.94%
lib/devise-security/rails.rb 2 100.0%
test/test_security_question_controller.rb 3 100.0%
Totals Coverage Status
Change from base Build 141: 0.0%
Covered Lines: 690
Relevant Lines: 776

💛 - Coveralls

1 similar comment
@coveralls
Copy link
Collaborator

coveralls commented Oct 13, 2018

Pull Request Test Coverage Report for Build 147

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 88.918%

Files with Coverage Reduction New Missed Lines %
test/test_password_expired_controller.rb 1 100.0%
lib/devise-security/controllers/helpers.rb 1 50.94%
lib/devise-security/rails.rb 2 100.0%
test/test_security_question_controller.rb 3 100.0%
Totals Coverage Status
Change from base Build 141: 0.0%
Covered Lines: 690
Relevant Lines: 776

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Oct 13, 2018

Pull Request Test Coverage Report for Build 159

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.363%

Totals Coverage Status
Change from base Build 158: 0.0%
Covered Lines: 895
Relevant Lines: 969

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 147

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 88.918%

Files with Coverage Reduction New Missed Lines %
test/test_password_expired_controller.rb 1 100.0%
lib/devise-security/controllers/helpers.rb 1 50.94%
lib/devise-security/rails.rb 2 100.0%
test/test_security_question_controller.rb 3 100.0%
Totals Coverage Status
Change from base Build 141: 0.0%
Covered Lines: 690
Relevant Lines: 776

💛 - Coveralls

Copy link
Contributor

@olbrich olbrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update rubocop.yml as well.

@dillonwelch
Copy link
Contributor Author

Not sure what update you mean - looks like the target version is currently 2.3, which matches up with the update I'm making.

@olbrich
Copy link
Contributor

olbrich commented Oct 15, 2018

TargetRubyVersion: 2.2

should be 2.3

@dillonwelch
Copy link
Contributor Author

Weird....on my local machine it was already showing as 2.3. I fixed it through Github.

@dillonwelch dillonwelch requested a review from olbrich October 15, 2018 17:09
@dillonwelch dillonwelch merged commit fe86b8e into devise-security:master Oct 15, 2018
@dillonwelch dillonwelch deleted the ruby-2.2-deprecated branch October 15, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants