Skip to content

Conversation

@murat
Copy link
Contributor

@murat murat commented Apr 27, 2018

I was not able to run the tests. 😞

@coveralls
Copy link
Collaborator

coveralls commented Apr 27, 2018

Pull Request Test Coverage Report for Build 110

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 90.238%

Files with Coverage Reduction New Missed Lines %
test/test_password_expired_controller.rb 1 100.0%
lib/devise-security/rails.rb 2 100.0%
test/test_security_question_controller.rb 3 100.0%
Totals Coverage Status
Change from base Build 107: 0.1%
Covered Lines: 758
Relevant Lines: 840

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 106

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.6%) to 88.959%

Files with Coverage Reduction New Missed Lines %
test/test_password_expired_controller.rb 1 100.0%
lib/devise-security/rails.rb 2 100.0%
test/test_security_question_controller.rb 4 96.97%
test/test_secure_validatable.rb 4 92.98%
Totals Coverage Status
Change from base Build 101: -0.6%
Covered Lines: 701
Relevant Lines: 788

💛 - Coveralls

Copy link
Contributor

@natebird natebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muratbsts - can you freeze the locales constant?

LOCALES = %w[ en es de it tr ].freeze

@natebird
Copy link
Contributor

As for the failing tests - shouldn't we be using the translation keys in the tests instead of the English strings?

@@ -0,0 +1,17 @@
en:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this top level key should correspond to the locale... should be tr instead of en.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@natebird
Copy link
Contributor

@muratbsts We also merged the PR which added some translation keys. If you can add the additional keys that would be great!

@olbrich olbrich added this to the Next Release milestone Apr 27, 2018
@murat
Copy link
Contributor Author

murat commented May 1, 2018

Hi, @natebird @olbrich I fixed the issues that you said. I ran tests on my machine with ruby v2.4.3 + rails v4.2/5.0/5.2

But travis jobs failed again. ☹️

Thank you, I learned new things about of testing.

# Generator for Rails to create or append to a Devise initializer.
class InstallGenerator < Rails::Generators::Base
LOCALES = %w[ en de it ]
LOCALES = %w[ en es de it tr ].freeze
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add fr to this list before the it and the tests will pass. Also please remove extra spaces at start and end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

@natebird natebird merged commit 4241b42 into devise-security:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants