-
Notifications
You must be signed in to change notification settings - Fork 154
Added Turkish locale #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 110
💛 - Coveralls |
Pull Request Test Coverage Report for Build 106
💛 - Coveralls |
natebird
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muratbsts - can you freeze the locales constant?
LOCALES = %w[ en es de it tr ].freeze
|
As for the failing tests - shouldn't we be using the translation keys in the tests instead of the English strings? |
config/locales/tr.yml
Outdated
| @@ -0,0 +1,17 @@ | |||
| en: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this top level key should correspond to the locale... should be tr instead of en.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
|
@muratbsts We also merged the PR which added some translation keys. If you can add the additional keys that would be great! |
| # Generator for Rails to create or append to a Devise initializer. | ||
| class InstallGenerator < Rails::Generators::Base | ||
| LOCALES = %w[ en de it ] | ||
| LOCALES = %w[ en es de it tr ].freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add fr to this list before the it and the tests will pass. Also please remove extra spaces at start and end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done
I was not able to run the tests. 😞