Desktop

[amorist]

TODO:

• app logo

• menubar app

• TouchBar

• build

Do you have any advices?

dev

yarn
yarn dev:desktop

build

yarn build:desktop

[amorist]

#2

[amorist]

default is menubar app

[brunolemos]

Thanks for your work @amorist, really appreciate it!

Here's a few thoughts:

Code sharing

I see lot's of code was copied from the web project, maybe we could do something to avoid duplication? Since it's a monorepo, one package can use code from the other. Or maybe we could use a npm script with a cp command, so we don't have to always manually duplicate changes between web and electron with the future changes.

Auto update

Can we setup the electron auto update so people always have the latest version?

Top arrow and settings style

See this example of arrow (the settings I'm still not sure if we should do like this):

Quick switch between menubar and desktop mode

I like how the app Harvest allows you to drag like this. See that the arrow always stay at the center, and then after o move a certain distance the arrow disappears and it goes into "desktop mode".

Please note that, as you saw my comment here, in the future I'd love to use react-native-macos and react-native-windows instead of Electron. I don't know if they will work, but I'll definitely play with them later.

[brunolemos]

External links

The authentication link is being opened inside electron, but it should open in the users' default browser, so the user can see the URL and trust it.

The other links are being opened inside electron as a popup, but they should open in the users's browser or replace the current electron window (need to test both ways to see which one is better).

A few bugs

• When scrolling horizontally (on a small window) it should jump to the next column. It does this on chrome mobile, not sure why not happening on electron
• App shows the default electron logo at the dock
• CSS bug when column event filters are opened (scroll not working and visible overflow content)

A few other enhancements

• Use circle icon instead of square
• Set min width to constants.MIN_COLUMN_WIDTH

[brunolemos]

electron process.versions.chrome 66.0.3359.181

Ok.

Forgot to mention Carlo, an Electron alternative by Google, instead of bundling with chrome it uses the Chrome from the user machine: https://github.com/GoogleChromeLabs/carlo

[amorist]

i will try

if (CSS.supports('scroll-snap-type: x mandatory')) {
  // use css scroll snap
} else {
  // other
}

[brunolemos]

i will try if (CSS.supports('scroll-snap-type: x mandatory')) {

Don't worry about this, electron will eventually upgrade chrome

[amorist]

i will try if (CSS.supports('scroll-snap-type: x mandatory')) {

Don't worry about this, electron will eventually upgrade chrome

Yes, electron 4.0.0-beta chrome version is 69.0.3497.106

[brunolemos]

We can use electron beta if it's not too buggy

[amorist]

We can use electron beta if it's not too buggy

OK!

[amorist]

Update:

• Code sharing WIP

• Auto update WIP

• Quick switch between menubar and desktop mode
  

• Top arrow and settings style
  Mojave dark mode causes a white line at the top of Electron apps electron/electron#13164 (comment)
  

• External links: The authentication link is being opened inside electron, but it should open in the users' default browser, so the user can see the URL and trust it. WIP

• When scrolling horizontally (on a small window) it should jump to the next column. It does this on chrome mobile, not sure why not happening on electron upgrade electron version 4.0.0-beta.11

• App shows the default electron logo at the dock unpackaged app default logo

• CSS bug when column event filters are opened (scroll not working and visible overflow content)
  A few other enhancements

• Use circle icon instead of square

• Set min width to constants.MIN_COLUMN_WIDTH

[brunolemos]

CSS bug when column event filters are opened (scroll not working and visible overflow content)

Fix is on master

Use circle icon instead of square

PNG assets are on master (https://github.com/devhubapp/devhub/tree/master/packages/mobile/assets)

[brunolemos]

Quick switch between menubar and desktop mode
Top arrow and settings style

Looking nice! 🤩

[brunolemos]

Code sharing

Don't worry about this now, we can improve this in the future

External links: The authentication link is being opened inside electron
Auto update

Just these left I think right? 🎉
I don't know much about the auto update, do I have to create some account somewhere?

[amorist]

Code signing is required on macOS

[amorist]

External links: The authentication link is being opened inside electron

I don't know how auth when authentication link opened by user default browser

now authentication link inside electron, other link use default browser

 app.on('web-contents-created', (event, webContents) => {
   webContents.on('new-window', (e, url) => {
     if (!url.includes('https://api.devhubapp.com/oauth')) {
       e.preventDefault()
       shell.openExternal(url)
     }
   })
 })

[brunolemos]

I plan to work on this today.

[brunolemos]

Thanks for your work @amorist, really appreciate it! 🎉🎉

I've opened #69 and will continue work there.

I'd love if you could keep helping with the desktop apps!
Hopefully we can launch them soon.