-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: documentation structure. #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f8d84c8 to
58a8ad6
Compare
7c211da to
990d706
Compare
3a1ff3c to
1e99264
Compare
|
Oooh, nice! How can I best review this? |
1e99264 to
4c08213
Compare
|
Added a |
4498c82 to
cd809d6
Compare
j08lue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the structure via the rendered version (pip install mkdocs-material && make serve-docs) but consider it to become an addition to our general eoAPI docs at https://eoapi.dev/intro/.
Suggestions
- I think the Overview may not be needed. The TOC is in the page menu and some of the more general information on eoAPI (e.g. about the services) is available from eoapi.dev/intro.
- Instead of a catch-all "Advanced" section, perhaps make a dedicated one for "Auth" and include the contributing / CI/CD information in a "Contributing" section somewhere, similar to https://eoapi.dev/contributing/ - could be a top-level nav item
Just my 2ct - if you think differently, pls let me know, then I'll approve nonetheless
docs/index.md
Outdated
| - `/stac` → STAC API | ||
| - `/raster` → TiTiler raster API | ||
| - `/vector` → TiPG vector API | ||
| - `/browser` → STAC Browser | ||
| - `/` → Documentation server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this content is pre this PR - But would it be useful to link to the actual components githubs/relevant docs pages here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, thanks! I added the github repo here. For the relevant docs i adjusted the main README.md to point to eoapi.dev/deployment/kubernetes with the goal to declare this for the one single place for docs, the eoapi.dev.
ef09af3 to
93a0c5a
Compare
93a0c5a to
aef611c
Compare
|
Thanks for your reviews! I tried to incorporate your feedback. @j08lue, I simplified the "overview" page, to avoid duplication. Made the advanced page the one about authentication. And added the repo where people find on the What do you think now? |
|
I merged for now. Happy to do any adjustments in follow-ups, @j08lue. I can imagine once we deploy it together on eoapi.dev we will have a slightly changing perspective and improvements will be necessary anyway. |
This refactor will allow us to deploy the k8s doc on eoapi.dev