Export RequestInit interface #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
requested changes
Feb 18, 2020
Owner
developit
left a comment
developit
left a comment
There was a problem hiding this comment.
The types we can certainly do, but I don't think we can export RequestInit itself.
| Request as NodeRequest, | ||
| Response as NodeResponse | ||
| Response as NodeResponse, | ||
| RequestInit as NodeRequestInit |
Owner
There was a problem hiding this comment.
unfetch doesn't support RequestInit, so exporting this from isomorphic-unfetch makes the interfaces incompatible depending on environment.
Contributor
Author
There was a problem hiding this comment.
Ah bummer. I guess close this PR then...
developit
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports the RequestInit interface for use in client code like described here #120.