Build command: Support multiple --image-name parameters #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love this idea! Super useful given how you have to use tags for versioning. 👍 |
chrmarti
reviewed
Jun 28, 2022
joshspicer
reviewed
Jun 29, 2022
chrmarti
approved these changes
Jul 6, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to tag the same image more than once.
eg -
devcontainer build --workspace-folder ./ --image-name alpine3 --image-name alpine3.0This is mainly needed for multiple tagging of multi-arch images created with
--platform.If the cli creates a multi arch image, and if you retag with
docker tagthen the new image ends up using architecture of the current machine for tagging.Hence, such multi-arch images needs to be tagged during image build else they won't support multi-architecture platform.