Debian8 #68
Debian8 #68
Conversation
* add support for debian 8 * cleanup kitchen.yml, add inspec support * remove oracle from meta file, bc it does not exist in ansible galaxy
templates/openssh.conf.j2
Outdated
| # | ||
| {% if ssh_client_cbc_required -%} | ||
| {% if ansible_distribution == 'Ubuntu' and ansible_distribution_version >= '14.04' -%} | ||
| {% if ansible_distribution == 'Ubuntu' and ansible_distribution_version >= '14.04' or (ansible_distribution == 'Debian' and ansible_distribution_version >= '8') -%} |
There was a problem hiding this comment.
For the sake of readability, put parens around the Ubuntu declarations as well, so the line looks like:
{% if (ansible_distribution == 'Ubuntu' and ansible_distribution_version >= '14.04') or (ansible_distribution == 'Debian' and ansible_distribution_version >= '8') -%}
That should be done throughout the template.
|
Added the parantheses, thanks! |
|
Great. I'll test this locally. Related ot discussion in #28, I'm maintaining custom vars for Debian hosts to override what the role defaults for Debian 8. If these changes account for my customizations, as they seem to, I'll be happy to remove the custom vars. |
|
This also fixes #61. |
|
I can definitely confirm that this fixes #61 on my end—excellent! The docs updates work great for local testing, no issues there. As far as Debian 8 support goes, I was able to remove custom vars from my project config, and the role as applied preserved the sshd config as expected with a single changed line. The hard-coded tests I use for kex, mac, and algos all passed, save one, which exposed that I was forcing support of the 👍 for merge, thanks for your hard work on this, @rndmh3ro! |
|
Thanks for testing, @conorsch! |
I implemented Debian 8 support (and removed debian 6 support, since its EOL) as well as making it easier to locally test the role with inspec.