This repository was archived by the owner on Dec 26, 2020. It is now read-only.
Fixed KexAlgorithms Conditional Statement #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the conditional statement which was missing an `elif`. (also now with same formating as openssh client template), sshd_kex_59_weak was omitted and is now re-added and `client` selector needed to be changed to `server` for sshd template.
templates/opensshd.conf.j2
Outdated
| # based on: https://bettercrypto.org/static/applied-crypto-hardening.pdf | ||
| {% if ansible_distribution == 'Ubuntu' and ansible_distribution_version >= '14.04' -%} | ||
| {% if ssh_client_weak_kex -%} | ||
| {% if sshd_server_weak_kex -%} |
There was a problem hiding this comment.
This should be ssh_server_weak_kex, without the d in ssh.
|
Thanks for the fix, there seems to be a typo in the variable. That's why the travis tests fail. |
|
Appreciate the correction and thanks for maintaining such a useful role. Fixed the variable typo. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the conditional statement which was missing an
elif. (also now with same formating as openssh client template),sshd_kex_59_weakwas omitted and is now re-added andclientselector needed to be changed toserverfor sshd template.