Skip to content
This repository was archived by the owner on Dec 26, 2020. It is now read-only.

Conversation

nununo
Copy link
Contributor

@nununo nununo commented Jul 13, 2020

Add section called "Changing the default port and idempotency" and reference to role ssh-hardening-fallback, a wrapper around this role which implements a fallback to port 22 when the configured port is unreachable.

Closes #299.

Signed-off-by: Nuno Godinho [email protected]

Add section called "Changing the default port and idempotency" and reference to role ssh-hardening-fallback, a wrapper around this role which implements a fallback to port 22 when the configured port is unreachable.

Signed-off-by: Nuno Godinho <[email protected]>
@nununo
Copy link
Contributor Author

nununo commented Jul 13, 2020

Hum... this is confusing. The DCO error message says:

Commit sha: 4a11070, Author: Nuno Godinho, Committer: GitHub; Expected "Nuno Godinho [email protected]", but got "Nuno Godinho [email protected]".

In my first PR attempt I got an error saying that the commit missed the sign-off. On this second one I signed-off the commit with the email I'm using in GitHub. And still DCO complains. Because clearly the expected email is not my real email...

I'm at a loss here. Any suggestions? I don't mind signing off with that weird email if you want me to.

Sorry about this and thank you for helping me sorting out this error.

Regards
Nuno

@rndmh3ro
Copy link
Member

Thank you for this! Great addition!

As for the dco I just set it manually to passed, so no need to do anything here.

The problem seems to be that you used the github ui to commit and that uses a different address than what you do locally.

@rndmh3ro rndmh3ro merged commit b4b3064 into dev-sec:master Jul 13, 2020
@nununo
Copy link
Contributor Author

nununo commented Jul 13, 2020

My pleasure. I am the one who thanks you for this great role!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idempotency when changing sshd ports
2 participants