Skip to content
This repository was archived by the owner on Dec 26, 2020. It is now read-only.

Conversation

oakey-b1
Copy link
Contributor

before the manually set ssh_host_key_files would be overwritten if the openssh-version was greater than 5.3

@rndmh3ro
Copy link
Member

Hey @oakey-b1, thanks for trying to improve our role!
As you can see in travis (https://travis-ci.org/dev-sec/ansible-ssh-hardening/jobs/254355014), this does not work. However I'm not actually sure why this happens.

Where do you see the problem with overriding the variables?

@oakey-b1
Copy link
Contributor Author

Hi @rndmh3ro,
the point for overwriting the vars is that if you have a (company) policy, which restricts the usage of some type of key you would have modify the role.

about the failing tests, looks like it is the defaults/main.yml, I'll test and then update it

before the manually set `ssh_host_key_files` would be overwritten if the openssh-version was greater than 5.3
@oakey-b1
Copy link
Contributor Author

fixed

@rndmh3ro rndmh3ro merged commit 7f9245a into dev-sec:master Jul 23, 2017
@rndmh3ro
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants