Add more details in warnings #16
Conversation
| if (!$res) { | ||
| warn "WrongResponse [$msg_type]"; | ||
| my $tx = $client->tx; | ||
| my $details = 'URL: ' . $tx->req->url; |
There was a problem hiding this comment.
shouldn't this check if tx object exists, like my $details = $tx ? 'URL: ' . $tx->req->url : ''; else it will give warnings
There was a problem hiding this comment.
Thanks for paying attention to that!
According to the implementation of MojoX::JSON::RPC::Client we shouldn't:
-
$callbackis invoked at https://metacpan.org/source/HENRYYKT/MojoX-JSON-RPC-0.10/lib/MojoX/JSON/RPC/Client.pm#L47 after doing_process_result -
in
_process_resultit already assumes$txis defined https://metacpan.org/source/HENRYYKT/MojoX-JSON-RPC-0.10/lib/MojoX/JSON/RPC/Client.pm#L104 . I.e. if it will be undefined, it willdiein non-our code already.
|
@basiliscos failing tests |
|
Tests fail in master too, because |
4 participants
No description provided.