hamed/refactor_connection_cubit #276
Open
+107
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahani-deriv
reviewed
Aug 7, 2023
| '$uri', | ||
| pingInterval: _websocketConnectTimeOut, | ||
| ); | ||
| _webSocket = ws.WebSocket(uri); |
There was a problem hiding this comment.
A quick question. Why is pingInterval changed from 10s to 1s? Isn't 1s too short?
There was a problem hiding this comment.
the main reason behind decreasing the ping interval is to find out the device disconnection as soon as disconnection happened because we are only relying on this ping to update the connection status.
sahani-deriv
approved these changes
Aug 7, 2023
ahrar-deriv
reviewed
Aug 8, 2023
| </array> | ||
| <key>UIViewControllerBasedStatusBarAppearance</key> | ||
| <false/> | ||
| <key>CADisableMinimumFrameDurationOnPhone</key> |
There was a problem hiding this comment.
this has been added automatically to Info.plist after the build and I suppose it is because of MinimumOSVersion 11.
bassam-deriv
approved these changes
Aug 8, 2023
ahrar-deriv
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.