Skip to content

Conversation

@prakashsurya
Copy link
Contributor

@prakashsurya prakashsurya commented Jul 7, 2025

Problem

When building the ZFS kernel modules, we don't generate BTF due to missing the "vmlinux" at the location expected by the kernel module build system.

Solution

The solution taken in this PR is to install the "dbgsym" kernel packages which install the "vmlinux" file, and then also add the symlink to that file at the location the kernel module build system expects.

Testing Done

  • git-ab-pre-push -b zfs is here

  • With this change, on ESX:

$ sudo bpftrace -v /opt/delphix/server/bin/nfs_delete.trace
INFO: node count: 111
Attaching 5 probes...

Program ID: 135

The verifier log:
processed 50 insns (limit 1000000) max_states_per_insn 0 total_states 3 peak_states 3 mark_read 1

Attaching kretfunc:nfsd:nfsd_unlink

Program ID: 136

The verifier log:
processed 2 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0

Attaching kfunc:zfs:zfs_ioc_pool_destroy

Program ID: 137

The verifier log:
processed 467 insns (limit 1000000) max_states_per_insn 0 total_states 11 peak_states 11 mark_read 7

Attaching kfunc:vmlinux:vfs_unlink

Program ID: 138

The verifier log:
processed 100 insns (limit 1000000) max_states_per_insn 0 total_states 6 peak_states 6 mark_read 2

Attaching kfunc:nfsd:nfsd_unlink

@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/dc5e12ac-6c62-48fd-a235-e6ef199d9c88 branch from de348df to aa2504d Compare July 7, 2025 19:53
@prakashsurya prakashsurya marked this pull request as ready for review July 7, 2025 19:56
Copy link

@tperkins-perforce tperkins-perforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prakashsurya prakashsurya enabled auto-merge (squash) July 7, 2025 21:22
Copy link

@david-mendez1 david-mendez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for the ab-pre-push test...

@prakashsurya prakashsurya merged commit df91d83 into develop Jul 8, 2025
17 checks passed
@prakashsurya prakashsurya deleted the dlpx/pr/prakashsurya/dc5e12ac-6c62-48fd-a235-e6ef199d9c88 branch July 8, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants