CE-579 Couchbase 1.30 >> Upgrade Logic >> KeyError while upgrading plugin #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satishk1536
force-pushed
the
dlpx/pr/satishk1536/7e716f64-4988-4cd6-9b25-8b2a68d7e0a3
branch
from
2a4eb92 to
cd55cbf
Compare
prasad-in
approved these changes
Nov 3, 2023
satishk1536
deleted the
dlpx/pr/satishk1536/7e716f64-4988-4cd6-9b25-8b2a68d7e0a3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The upgrade logic throws a KeyError because it searches for a variable name instead of the property name specified in
schema.json.Solution
Using the property name solves the issue.
Unit test is **Done**.Testing Done