Skip to content

Improve appearance of TSaveSourceDlg #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks done
delphidabbler opened this issue Apr 29, 2025 · 1 comment
Open
6 tasks done

Improve appearance of TSaveSourceDlg #166

delphidabbler opened this issue Apr 29, 2025 · 1 comment
Assignees
Labels
completed Work has been completed on this issue and changes have been committed to `develop` branch.. ui improvement An update to the user interface

Comments

@delphidabbler
Copy link
Owner

delphidabbler commented Apr 29, 2025

The following things in TSaveSourceDlg could do with some attention:

  • The File Encoding combo would be better if it was disabled when there is only one supported encoding.
  • When ANSI encoding is available, the text displayed in the File Encoding combo is ANSI (Default). That makes it look like the ANSI option is the default choice rather than what it is supposed to mean, which is that the system default code page will be used when ANSI is selected. A better choice of text is needed.
  • When RTF is selected, the encoding is displayed in the Save Unit and Save Annotated Source dialogues is ANSI where it really should be ASCII.
  • The title of the dialogue displayed when File | Save Annotated Source menu option is selected is Save xxx Snippet, which doesn't mention Annotated, but probably should.
  • The title of the Save Snippet Information dialogue box doesn't mention the snippet name, unlike the annotated source dialogue box. Things need to be standardised.
  • The suggested file name in the Save Snippet Information is always SnippetInfo whereas the file name in the similar Save Annotated dialogue box is named after the snippet.
@delphidabbler delphidabbler added accepted Accepted for implementation / fixing ui improvement An update to the user interface labels Apr 29, 2025
@delphidabbler delphidabbler self-assigned this Apr 29, 2025
@github-project-automation github-project-automation bot moved this to Considering in CodeSnip Apr 29, 2025
@delphidabbler delphidabbler moved this from Considering to In progress in CodeSnip Apr 29, 2025
@delphidabbler
Copy link
Owner Author

All encoding names are to be standardised and ANSI encoding is to be displayed as ANSI Code Page nnn where nnn is the system default code page.

This has been implemented locally and will be pushed to develop one this issue is completed.

@delphidabbler delphidabbler added completed Work has been completed on this issue and changes have been committed to `develop` branch.. and removed accepted Accepted for implementation / fixing labels Apr 29, 2025
@delphidabbler delphidabbler moved this from In progress to Done - awaiting release in CodeSnip Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed Work has been completed on this issue and changes have been committed to `develop` branch.. ui improvement An update to the user interface
Projects
Status: Done - awaiting release
Development

No branches or pull requests

1 participant