Add ability to specify lanIp argument (fix #27) #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekimasoon
reviewed
Sep 3, 2018
tartinesKiller
force-pushed
the
master
branch
from
cd5b633 to
67e9d76
Compare
Removed console.log
tartinesKiller
force-pushed
the
master
branch
from
67e9d76 to
f5c4e23
Compare
dekimasoon
reviewed
Sep 3, 2018
Owner
dekimasoon
left a comment
dekimasoon
left a comment
There was a problem hiding this comment.
Thank you so much for your PR, It is awesome!
I commented on a small point. Please check it out.
redirect.ejs
Outdated
| var protocol = '<%- https ? "https" : "http" %>' | ||
| var port = '<%- port %>' | ||
| var platform = device.platform.toLowerCase() | ||
| if(platform === 'amazon-fireos') { |
Owner
There was a problem hiding this comment.
Please put a space before the parentheses.
And I think we should add some comments to explain why this branch is necessary.
Author
There was a problem hiding this comment.
Added, I hope it's not too verbose!
Owner
|
I just released your updates as v1.0.0-beta.8. Thanks! |
Author
|
Great! Thanks to you, happy to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.