Add LoRA LR for DS Chat steps 1-3 #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekurile
requested review from
jeffra,
samyam,
tjruwase,
ShadenSmith,
conglongli,
awan-10,
eltonzheng,
minjiaz,
RezaYazdaniAminabadi,
duli2012,
mrwyattii,
yaozhewei,
arashb and
xiaoxiawu-microsoft
as code owners
awan-10
approved these changes
Aug 12, 2023
LeetJoe
pushed a commit
to LeetJoe/DeepSpeedExamples
that referenced
this pull request
Sep 15, 2023
This PR adds an explicit LoRA learning rate argument for DS Chat steps 1 through 3. Step 1: - lora_learning_rate Step 2: - lora_learning_rate Step 3: - actor_lora_learning_rate - critic_lora_learning_rate
hwchen2017
pushed a commit
that referenced
this pull request
Jun 8, 2025
This PR adds an explicit LoRA learning rate argument for DS Chat steps 1 through 3. Step 1: - lora_learning_rate Step 2: - lora_learning_rate Step 3: - actor_lora_learning_rate - critic_lora_learning_rate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit LoRA learning rate argument for DS Chat steps 1 through 3.
lora_learning_ratelora_learning_rateactor_lora_learning_ratecritic_lora_learning_rate