-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Add generation_kwargs to run methods of Agent #9616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Sebastian Husch Lee <[email protected]>
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Co-authored-by: Sebastian Husch Lee <[email protected]>
Co-authored-by: Sebastian Husch Lee <[email protected]>
…agent-with-generator_kwargs
@sjrl I updated the PR, addressed your comments and added release notes. Hopefully ready to merge |
@sjrl any chance you find some minutes to look over it? |
Hey @jdb78 apologies for the slow response. We are discussing internally if we'd prefer to make this a more general |
Related Issues
Proposed Changes:
added a generation_kwargs parameter to Agent which are to be passed to LLM
How did you test it?
added generation_kwargs to unit test run
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.