-
Notifications
You must be signed in to change notification settings - Fork 202
fix: chat roles for model responses in chat generators #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anakin87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please also update these other occurrences
wrong usage example:
haystack-core-integrations/integrations/ollama/examples/chat_generator_example.py
Line 14 in 3b05662
| ChatMessage.from_system( |
wrong tests:
haystack-core-integrations/integrations/amazon_bedrock/tests/test_chat_generator.py
Line 203 in 3b05662
| messages = [ChatMessage.from_system("What is the biggest city in United States?")] |
haystack-core-integrations/integrations/google_ai/tests/generators/chat/test_chat_gemini.py
Line 260 in 3b05662
| ChatMessage.from_system(content="It's an arithmetic operation."), |
integrations/google_ai/src/haystack_integrations/components/generators/google_ai/chat/gemini.py
Show resolved
Hide resolved
anakin87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Feel free to merge.
Having more tests would help.
See #1019 (comment)
Related Issues
Proposed Changes:
systemtoassistantfor bothGoogleGeminiChatGeneratorandVertexAIGeminiChatGenerator.How did you test it?
Ran existing tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.