Added custom sound & toaster support #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Also this is the config created in the video (sample audio is stored inside it): (you dont really need either but, just in case you for any reason have issues testing on your end) |
Owner
|
I don't really think this falls within the scope of this plugin |
Author
|
Howdy. Because Im not really utilizing any additional features from BdApi I believe it wont add any meaningful maintenance cost (all I used BdApi for is reading/writing from/to settings & displaying UI in the same manner your plugin does for existing features). So I see no harm in having it really. https://betterdiscord.app/plugin/NotificationSounds also does not work in combination with your plugin out of the box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://youtu.be/rm3vwYsMQ8E