Update templates.js #435
Open
Update templates.js #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix TrackingIdentifier super call Change super(options) → super() to prevent the raw options object being injected into the sequence. Closes dcmjs-org#434
✅ Deploy Preview for dcmjs2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| class TrackingIdentifier extends Template { | ||
| constructor(options) { | ||
| super(options); | ||
| super(); |
There was a problem hiding this comment.
It isn't just this one, but every Template extension (5 of them) in this appears to be wrong. Can you go through them and update the others?
There was a problem hiding this comment.
@nr59684 do you plan to follow up on this PR?
We very much welcome your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TrackingIdentifier super call
Change super(options) → super() to prevent the raw options object being injected into the sequence.
Closes #434