This repository was archived by the owner on Jan 13, 2020. It is now read-only.
Improvement: Pass element that did move #209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to track what element did change as we don't have full tree rendered, this pass the moved element so we can get data from moved element attributes.
|
You can send this PR to https://github.com/RamonSmit/Nestable2 (The most maintainable fork of this project). |
|
Nestable2 have event that contain the element, so no need to my patch. But thanks for the tip, i didn't know there is continuation/compatible fork. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to track what element did change as we don't have full tree rendered, this pass the moved element so we can get data from moved element attributes.
This change will simply pass the moved element with change event.