chore: update onClick for button and link with mitosis plugin #4392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-button-click-double-call-2 |
michaelmkraus
approved these changes
Jun 18, 2025
mfranzke
reviewed
Jun 19, 2025
| console.log(json.name); | ||
| if (['DBButton', 'DBLink'].includes(json.name)) { | ||
| if (json.pluginData.target === 'vue') { | ||
| console.log(json.state); |
There was a problem hiding this comment.
@nmerget should this console.log remain in there?
nmerget
added a commit
that referenced
this pull request
Jun 27, 2025
…reserving native behaviour (#4359) * fix(button): prevent duplicate click events by stopping propagation * fix(button): prevent duplicate click events by stopping propagation * fix(button): prevent duplicate click events across frameworks while preserving native behavior * chore: update onClick for button and link with mitosis plugin (#4392) --------- Co-authored-by: Maximilian Franzke <[email protected]> Co-authored-by: Nicolas Merget <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Further comments