Skip to content

fix: issue with events triggering twice in angular #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix: issue with events triggering twice in angular #4135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/src/components/button/button.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export default function DBButton(props: DBButtonProps) {
// jscpd:ignore-start
const state = useStore<DBButtonState>({
handleClick: (event: ClickEvent<HTMLButtonElement>) => {
event.stopPropagation();
if (props.onClick) {
props.onClick(event);
}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/card/card.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export default function DBCard(props: DBCardProps) {
// jscpd:ignore-start
const state = useStore<DBCardState>({
handleClick: (event: ClickEvent<HTMLElement>) => {
event.stopPropagation();
if (props.onClick) {
props.onClick(event);
}
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/components/checkbox/checkbox.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export default function DBCheckbox(props: DBCheckboxProps) {
}
},
handleChange: (event: ChangeEvent<HTMLInputElement>) => {
event.stopPropagation();
if (props.onChange) {
props.onChange(event);
}
Expand All @@ -97,11 +98,13 @@ export default function DBCheckbox(props: DBCheckboxProps) {
state.handleValidation();
},
handleBlur: (event: InteractionEvent<HTMLInputElement> | any) => {
event.stopPropagation();
if (props.onBlur) {
props.onBlur(event);
}
},
handleFocus: (event: InteractionEvent<HTMLInputElement> | any) => {
event.stopPropagation();
if (props.onFocus) {
props.onFocus(event);
}
Expand Down
4 changes: 4 additions & 0 deletions packages/components/src/components/input/input.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ export default function DBInput(props: DBInputProps) {
}
},
handleInput: (event: InputEvent<HTMLInputElement>) => {
event.stopPropagation();
useTarget({
vue: () => {
if (props.input) {
Expand All @@ -123,6 +124,7 @@ export default function DBInput(props: DBInputProps) {
state.handleValidation();
},
handleChange: (event: ChangeEvent<HTMLInputElement>) => {
event.stopPropagation();
if (props.onChange) {
props.onChange(event);
}
Expand All @@ -134,11 +136,13 @@ export default function DBInput(props: DBInputProps) {
state.handleValidation();
},
handleBlur: (event: InteractionEvent<HTMLInputElement> | any) => {
event.stopPropagation();
if (props.onBlur) {
props.onBlur(event);
}
},
handleFocus: (event: InteractionEvent<HTMLInputElement> | any) => {
event.stopPropagation();
if (props.onFocus) {
props.onFocus(event);
}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/link/link.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export default function DBLink(props: DBLinkProps) {
// jscpd:ignore-start
const state = useStore<DBLinkState>({
handleClick: (event: ClickEvent<HTMLAnchorElement>) => {
event.stopPropagation();
if (props.onClick) {
props.onClick(event);
}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/navigation-item/navigation-item.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export default function DBNavigationItem(props: DBNavigationItemProps) {
}
},
handleClick: (event: ClickEvent<HTMLButtonElement> | any) => {
event.stopPropagation();
if (props.onClick) {
props.onClick(event);
}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/notification/notification.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default function DBNotification(props: DBNotificationProps) {
// jscpd:ignore-start
const state = useStore<DBNotificationState>({
handleClose: (event: ClickEvent<HTMLButtonElement> | any) => {
event.stopPropagation();
if (props.onClose) {
props.onClose(event);
}
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/components/radio/radio.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export default function DBRadio(props: DBRadioProps) {
initialized: false,
_id: undefined,
handleChange: (event: ChangeEvent<HTMLInputElement> | any) => {
event.stopPropagation();
if (props.onChange) {
props.onChange(event);
}
Expand All @@ -40,11 +41,13 @@ export default function DBRadio(props: DBRadioProps) {
});
},
handleBlur: (event: InteractionEvent<HTMLInputElement> | any) => {
event.stopPropagation();
if (props.onBlur) {
props.onBlur(event);
}
},
handleFocus: (event: InteractionEvent<HTMLInputElement> | any) => {
event.stopPropagation();
if (props.onFocus) {
props.onFocus(event);
}
Expand Down
5 changes: 5 additions & 0 deletions packages/components/src/components/select/select.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,13 @@ export default function DBSelect(props: DBSelectProps) {
}
},
handleClick: (event: ClickEvent<HTMLSelectElement> | any) => {
event.stopPropagation();
if (props.onClick) {
props.onClick(event);
}
},
handleInput: (event: InputEvent<HTMLSelectElement> | any) => {
event.stopPropagation();
useTarget({
vue: () => {
if (props.input) {
Expand All @@ -123,6 +125,7 @@ export default function DBSelect(props: DBSelectProps) {
state.handleValidation();
},
handleChange: (event: ChangeEvent<HTMLSelectElement> | any) => {
event.stopPropagation();
if (props.onChange) {
props.onChange(event);
}
Expand All @@ -134,11 +137,13 @@ export default function DBSelect(props: DBSelectProps) {
state.handleValidation();
},
handleBlur: (event: InteractionEvent<HTMLSelectElement> | any) => {
event.stopPropagation();
if (props.onBlur) {
props.onBlur(event);
}
},
handleFocus: (event: InteractionEvent<HTMLSelectElement> | any) => {
event.stopPropagation();
if (props.onFocus) {
props.onFocus(event);
}
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/components/switch/switch.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export default function DBSwitch(props: DBSwitchProps) {
default: false
}),
handleChange: (event: ChangeEvent<HTMLInputElement>) => {
event.stopPropagation();
if (props.onChange) {
props.onChange(event);
}
Expand All @@ -54,11 +55,13 @@ export default function DBSwitch(props: DBSwitchProps) {
});
},
handleBlur: (event: InteractionEvent<HTMLInputElement>) => {
event.stopPropagation();
if (props.onBlur) {
props.onBlur(event);
}
},
handleFocus: (event: InteractionEvent<HTMLInputElement>) => {
event.stopPropagation();
if (props.onFocus) {
props.onFocus(event);
}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/tab-item/tab-item.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export default function DBTabItem(props: DBTabItemProps) {
}
},
handleChange: (event: any) => {
event.stopPropagation();
if (props.onChange) {
props.onChange(event);
}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/tabs/tabs.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export default function DBTabs(props: DBTabsProps) {
}
},
handleChange: (event: any) => {
event.stopPropagation();
const list = event.target?.closest('ul');
const listItem =
// db-tab-item for angular and stencil wrapping elements
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/tag/tag.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default function DBTag(props: DBTagProps) {
const state = useStore<DBTagState>({
initialized: false,
handleRemove: (event?: ClickEvent<HTMLButtonElement>) => {
event?.stopPropagation();
if (props.onRemove) {
props.onRemove(event);
}
Expand Down
4 changes: 4 additions & 0 deletions packages/components/src/components/textarea/textarea.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export default function DBTextarea(props: DBTextareaProps) {
}
},
handleInput: (event: InputEvent<HTMLTextAreaElement>) => {
event.stopPropagation();
useTarget({
vue: () => {
if (props.input) {
Expand All @@ -111,6 +112,7 @@ export default function DBTextarea(props: DBTextareaProps) {
state.handleValidation();
},
handleChange: (event: ChangeEvent<HTMLTextAreaElement>) => {
event.stopPropagation();
if (props.onChange) {
props.onChange(event);
}
Expand All @@ -121,11 +123,13 @@ export default function DBTextarea(props: DBTextareaProps) {
state.handleValidation();
},
handleBlur: (event: InteractionEvent<HTMLTextAreaElement> | any) => {
event.stopPropagation();
if (props.onBlur) {
props.onBlur(event);
}
},
handleFocus: (event: InteractionEvent<HTMLTextAreaElement> | any) => {
event.stopPropagation();
if (props.onFocus) {
props.onFocus(event);
}
Expand Down
Loading