Skip to content

chore: allow cypress postinstall script #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

davidlj95
Copy link
Owner

Issue or need

Recently, CI/CD jobs related to E2E testing with Cypress started to fail. See https://github.com/davidlj95/ngx/actions/runs/13480235256/job/37664531817?pr=1113 for instance.

The reason is that cypress binary is missing.

It is very probably due to the major changes introduced when updating to pnpm v10. Specifically, that now pnpm doesn't run postinstall scripts of installed deps. Unless they are approved.

See the related Cypress issue about it

Proposed changes

Allow the postinstall script to install Cypress (via pnpm approve-builds cmd) and keep E2E tests working.

Not downgrading pnpm as the fix is quite straight forward and nothing else is failing.

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

@davidlj95 davidlj95 enabled auto-merge (squash) February 24, 2025 19:36
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (590d3b6) to head (b1478f1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines          535       535           
  Branches        64        64           
=========================================
  Hits           535       535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit 151e795 into main Feb 24, 2025
40 checks passed
@davidlj95 davidlj95 deleted the stacked/chore-allow-cypress-postinstall-script branch February 24, 2025 19:40
Copy link

📦 Bundle size (Angular v17)

Git ref: b1478f12afdf1b18ef9bae4de9899053bd467a0f

Module file Size Base size Difference
ngx-meta-core.mjs 0 bytes (0B) 3205 bytes (3.2KiB) -100.00%: -3205 bytes (-3.2KiB)
ngx-meta-json-ld.mjs 0 bytes (0B) 219 bytes (219B) -100.00%: -219 bytes (-219B)
ngx-meta-open-graph.mjs 0 bytes (0B) 1033 bytes (1.1KiB) -100.00%: -1033 bytes (-1.1KiB)
ngx-meta-routing.mjs 0 bytes (0B) 394 bytes (394B) -100.00%: -394 bytes (-394B)
ngx-meta-standard.mjs 0 bytes (0B) 937 bytes (937B) -100.00%: -937 bytes (-937B)
ngx-meta-twitter-card.mjs 0 bytes (0B) 533 bytes (533B) -100.00%: -533 bytes (-533B)
ngx-meta-core.mjs 3205 bytes (3.2KiB) 0 bytes (0B) %: 3205 bytes (3.2KiB)
ngx-meta-json-ld.mjs 219 bytes (219B) 0 bytes (0B) %: 219 bytes (219B)
ngx-meta-open-graph.mjs 1033 bytes (1.1KiB) 0 bytes (0B) %: 1033 bytes (1.1KiB)
ngx-meta-routing.mjs 394 bytes (394B) 0 bytes (0B) %: 394 bytes (394B)
ngx-meta-standard.mjs 937 bytes (937B) 0 bytes (0B) %: 937 bytes (937B)
ngx-meta-twitter-card.mjs 533 bytes (533B) 0 bytes (0B) %: 533 bytes (533B)
Total 6321 bytes (6.2KiB) 6321 bytes (6.2KiB) No change

Copy link

📦 Bundle size (Angular v18)

Git ref: b1478f12afdf1b18ef9bae4de9899053bd467a0f

Module file Size Base size Difference
ngx-meta-core.mjs 0 bytes (0B) 3205 bytes (3.2KiB) -100.00%: -3205 bytes (-3.2KiB)
ngx-meta-json-ld.mjs 0 bytes (0B) 219 bytes (219B) -100.00%: -219 bytes (-219B)
ngx-meta-open-graph.mjs 0 bytes (0B) 1033 bytes (1.1KiB) -100.00%: -1033 bytes (-1.1KiB)
ngx-meta-routing.mjs 0 bytes (0B) 394 bytes (394B) -100.00%: -394 bytes (-394B)
ngx-meta-standard.mjs 0 bytes (0B) 937 bytes (937B) -100.00%: -937 bytes (-937B)
ngx-meta-twitter-card.mjs 0 bytes (0B) 533 bytes (533B) -100.00%: -533 bytes (-533B)
ngx-meta-core.mjs 3205 bytes (3.2KiB) 0 bytes (0B) %: 3205 bytes (3.2KiB)
ngx-meta-json-ld.mjs 219 bytes (219B) 0 bytes (0B) %: 219 bytes (219B)
ngx-meta-open-graph.mjs 1033 bytes (1.1KiB) 0 bytes (0B) %: 1033 bytes (1.1KiB)
ngx-meta-routing.mjs 394 bytes (394B) 0 bytes (0B) %: 394 bytes (394B)
ngx-meta-standard.mjs 937 bytes (937B) 0 bytes (0B) %: 937 bytes (937B)
ngx-meta-twitter-card.mjs 533 bytes (533B) 0 bytes (0B) %: 533 bytes (533B)
Total 6321 bytes (6.2KiB) 6321 bytes (6.2KiB) No change

Copy link

📦 Bundle size (Angular v19)

Git ref: b1478f12afdf1b18ef9bae4de9899053bd467a0f

Module file Size Base size Difference
ngx-meta-core.mjs 0 bytes (0B) 3205 bytes (3.2KiB) -100.00%: -3205 bytes (-3.2KiB)
ngx-meta-json-ld.mjs 0 bytes (0B) 219 bytes (219B) -100.00%: -219 bytes (-219B)
ngx-meta-open-graph.mjs 0 bytes (0B) 1033 bytes (1.1KiB) -100.00%: -1033 bytes (-1.1KiB)
ngx-meta-routing.mjs 0 bytes (0B) 394 bytes (394B) -100.00%: -394 bytes (-394B)
ngx-meta-standard.mjs 0 bytes (0B) 937 bytes (937B) -100.00%: -937 bytes (-937B)
ngx-meta-twitter-card.mjs 0 bytes (0B) 533 bytes (533B) -100.00%: -533 bytes (-533B)
ngx-meta-core.mjs 3205 bytes (3.2KiB) 0 bytes (0B) %: 3205 bytes (3.2KiB)
ngx-meta-json-ld.mjs 219 bytes (219B) 0 bytes (0B) %: 219 bytes (219B)
ngx-meta-open-graph.mjs 1033 bytes (1.1KiB) 0 bytes (0B) %: 1033 bytes (1.1KiB)
ngx-meta-routing.mjs 394 bytes (394B) 0 bytes (0B) %: 394 bytes (394B)
ngx-meta-standard.mjs 937 bytes (937B) 0 bytes (0B) %: 937 bytes (937B)
ngx-meta-twitter-card.mjs 533 bytes (533B) 0 bytes (0B) %: 533 bytes (533B)
Total 6321 bytes (6.2KiB) 6321 bytes (6.2KiB) No change

Copy link

📦 Bundle size (Angular v15)

Git ref: b1478f12afdf1b18ef9bae4de9899053bd467a0f

Module file Size Base size Difference
ngx-meta-core.mjs 0 bytes (0B) 3386 bytes (3.4KiB) -100.00%: -3386 bytes (-3.4KiB)
ngx-meta-json-ld.mjs 0 bytes (0B) 198 bytes (198B) -100.00%: -198 bytes (-198B)
ngx-meta-open-graph.mjs 0 bytes (0B) 804 bytes (804B) -100.00%: -804 bytes (-804B)
ngx-meta-routing.mjs 0 bytes (0B) 373 bytes (373B) -100.00%: -373 bytes (-373B)
ngx-meta-standard.mjs 0 bytes (0B) 739 bytes (739B) -100.00%: -739 bytes (-739B)
ngx-meta-twitter-card.mjs 0 bytes (0B) 412 bytes (412B) -100.00%: -412 bytes (-412B)
ngx-meta-core.mjs 3386 bytes (3.4KiB) 0 bytes (0B) %: 3386 bytes (3.4KiB)
ngx-meta-json-ld.mjs 198 bytes (198B) 0 bytes (0B) %: 198 bytes (198B)
ngx-meta-open-graph.mjs 804 bytes (804B) 0 bytes (0B) %: 804 bytes (804B)
ngx-meta-routing.mjs 373 bytes (373B) 0 bytes (0B) %: 373 bytes (373B)
ngx-meta-standard.mjs 739 bytes (739B) 0 bytes (0B) %: 739 bytes (739B)
ngx-meta-twitter-card.mjs 412 bytes (412B) 0 bytes (0B) %: 412 bytes (412B)
Total 5912 bytes (5.8KiB) 5912 bytes (5.8KiB) No change

Copy link

📦 Bundle size (Angular v16)

Git ref: b1478f12afdf1b18ef9bae4de9899053bd467a0f

Module file Size Base size Difference
ngx-meta-core.mjs 0 bytes (0B) 3411 bytes (3.4KiB) -100.00%: -3411 bytes (-3.4KiB)
ngx-meta-json-ld.mjs 0 bytes (0B) 193 bytes (193B) -100.00%: -193 bytes (-193B)
ngx-meta-open-graph.mjs 0 bytes (0B) 804 bytes (804B) -100.00%: -804 bytes (-804B)
ngx-meta-routing.mjs 0 bytes (0B) 379 bytes (379B) -100.00%: -379 bytes (-379B)
ngx-meta-standard.mjs 0 bytes (0B) 739 bytes (739B) -100.00%: -739 bytes (-739B)
ngx-meta-twitter-card.mjs 0 bytes (0B) 470 bytes (470B) -100.00%: -470 bytes (-470B)
ngx-meta-core.mjs 3411 bytes (3.4KiB) 0 bytes (0B) %: 3411 bytes (3.4KiB)
ngx-meta-json-ld.mjs 193 bytes (193B) 0 bytes (0B) %: 193 bytes (193B)
ngx-meta-open-graph.mjs 804 bytes (804B) 0 bytes (0B) %: 804 bytes (804B)
ngx-meta-routing.mjs 379 bytes (379B) 0 bytes (0B) %: 379 bytes (379B)
ngx-meta-standard.mjs 739 bytes (739B) 0 bytes (0B) %: 739 bytes (739B)
ngx-meta-twitter-card.mjs 470 bytes (470B) 0 bytes (0B) %: 470 bytes (470B)
Total 5996 bytes (5.9KiB) 5996 bytes (5.9KiB) No change

Copy link

🎉 This PR is included in version 1.0.0-beta.37 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant