-
Notifications
You must be signed in to change notification settings - Fork 1
chore: allow cypress postinstall script #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow cypress postinstall script #1122
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 535 535
Branches 64 64
=========================================
Hits 535 535 ☔ View full report in Codecov by Sentry. |
📦 Bundle size (Angular v17)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v19)Git ref:
|
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
🎉 This PR is included in version 1.0.0-beta.37 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
Recently, CI/CD jobs related to E2E testing with Cypress started to fail. See https://github.com/davidlj95/ngx/actions/runs/13480235256/job/37664531817?pr=1113 for instance.
The reason is that
cypress
binary is missing.It is very probably due to the major changes introduced when updating to
pnpm
v10. Specifically, that nowpnpm
doesn't runpostinstall
scripts of installed deps. Unless they are approved.See the related Cypress issue about it
Proposed changes
Allow the
postinstall
script to install Cypress (viapnpm approve-builds
cmd) and keep E2E tests working.Not downgrading
pnpm
as the fix is quite straight forward and nothing else is failing.Quick reminders