Skip to content

Conversation

kakserpom
Copy link
Contributor

@kakserpom kakserpom commented Jun 20, 2025

  • lifetime flowing from input to output with different syntax can be confusing
  • mutable borrow from immutable input(s)
  • chore(clippy): warning: implicit borrow as raw pointer

 - lifetime flowing from input to output with different syntax can be confusing
 - mutable borrow from immutable input(s)
@coveralls
Copy link

coveralls commented Jun 20, 2025

Pull Request Test Coverage Report for Build 15788182852

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 56 (10.71%) changed or added relevant lines in 13 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 22.034%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/builders/class.rs 0 1 0.0%
src/types/iterable.rs 0 1 0.0%
src/types/iterator.rs 1 2 50.0%
src/types/zval.rs 1 2 50.0%
src/zend/class.rs 0 1 0.0%
src/zend/linked_list.rs 0 2 0.0%
src/types/callable.rs 0 3 0.0%
src/types/array.rs 0 5 0.0%
src/types/class_object.rs 0 5 0.0%
src/zend/function.rs 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/zend/streams.rs 1 0.0%
src/zend/globals.rs 2 18.72%
Totals Coverage Status
Change from base Build 15715478100: 0.0%
Covered Lines: 871
Relevant Lines: 3953

💛 - Coveralls

@Xenira
Copy link
Collaborator

Xenira commented Jun 20, 2025

@kakserpom cargo fmt --all and the pipeline should be green :)

@kakserpom
Copy link
Contributor Author

@Xenira, it cannot fix mutable borrow from immutable input(s) automagically. So we need to change it or suppress it.

@Qard Qard mentioned this pull request Jun 27, 2025
@ptondereau ptondereau merged commit 688201a into davidcole1340:master Jun 27, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants