Skip to content

Conversation

Xenira
Copy link
Collaborator

@Xenira Xenira commented May 29, 2025

BREAKING CHANGE: Methods and Properties are renamed to camelCase by default. Classes to PascalCase and constants to UPPER_CASE.

Refs: #189

@Xenira Xenira linked an issue May 29, 2025 that may be closed by this pull request
@Xenira Xenira force-pushed the 189-prop-attribute-should-rename-fields-to-camelcase-by-default branch from e9e5d1f to a6d076e Compare May 29, 2025 19:22
@coveralls
Copy link

coveralls commented May 29, 2025

Pull Request Test Coverage Report for Build 15715261521

Details

  • 16 of 35 (45.71%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 22.034%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/macros/src/parsing.rs 16 18 88.89%
crates/macros/src/constant.rs 0 3 0.0%
crates/macros/src/function.rs 0 3 0.0%
crates/macros/src/class.rs 0 4 0.0%
crates/macros/src/impl_.rs 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
crates/macros/src/constant.rs 1 0.0%
crates/macros/src/parsing.rs 1 89.66%
Totals Coverage Status
Change from base Build 15714784648: -0.04%
Covered Lines: 871
Relevant Lines: 3953

💛 - Coveralls

@joelwurtz
Copy link
Contributor

It seems php functions are also renamed to camelCase by default where it should be snake_case no ?

@Xenira
Copy link
Collaborator Author

Xenira commented Jun 3, 2025

@joelwurtz psr does not mention functions directly as far as I can tell. Seems both camel and snake case are possibilities here.

I like the idea of using snake here though.

@Xenira Xenira force-pushed the 189-prop-attribute-should-rename-fields-to-camelcase-by-default branch 2 times, most recently from 0309224 to 77214e4 Compare June 3, 2025 19:02
@Xenira Xenira force-pushed the 189-prop-attribute-should-rename-fields-to-camelcase-by-default branch 3 times, most recently from de32ad4 to 6028968 Compare June 17, 2025 18:20
BREAKING CHANGE: Methods and Properties are renamed to camelCase by default. Classes to PascalCase and constants to UPPER_CASE.

Refs: #189
@Xenira Xenira force-pushed the 189-prop-attribute-should-rename-fields-to-camelcase-by-default branch from 6028968 to 839c597 Compare June 17, 2025 18:27
@Xenira Xenira added this to the macro rework milestone Jun 17, 2025
@Xenira Xenira merged commit 660f308 into master Jun 17, 2025
35 checks passed
@davidcole1340 davidcole1340 mentioned this pull request Jun 17, 2025
@Xenira Xenira deleted the 189-prop-attribute-should-rename-fields-to-camelcase-by-default branch July 1, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[prop] attribute should rename fields to camelCase by default
3 participants