Funny business with zend_array

[kakserpom]

#[php_function]
pub fn make_a_peculiar_array() -> Result<Zval> {
    let mut array = zend_array::with_capacity(5);
    array.insert_at_index(1, false)?;
    array.insert("1", true)?;
    array.into_zval(false)
}

<?php
$array = make_a_peculiar_array();
var_dump([
    '$array' => $array,
    "'1' exists" => array_key_exists("1", $array),
    "'1' value" => $array["1"],
    'count($array)' => count($array)
]);
unset($array["1"]);
var_dump([
    "array_key_exists('1', \$array)" => array_key_exists('1', $array),
    "isset(\$array['1'])" => isset($array['1']),
    'count($array)' => count($array),
    '$array' => $array,
]);

Output:

array(4) {
  ["$array"]=>
  array(2) {
    [1]=>
    bool(false)
    ["1"]=>
    bool(true)
  }
  ["'1' exists"]=>
  bool(true)
  ["'1' value"]=>
  bool(false)
  ["count($array)"]=>
  int(2)
}
array(4) {
  ["array_key_exists('1', $array)"]=>
  bool(false)
  ["isset($array['1'])"]=>
  bool(false)
  ["count($array)"]=>
  int(1)
  ["$array"]=>
  array(1) {
    ["1"]=>
    bool(true)
  }
}

ZendHashTable::insert() probably should insert numeric keys as indexes.

Also note that insert_at_index() accepts u64 and thus doesn't support negative indexes.

> var_dump([-1 => 1]);
array(1) {
  [-1]=>
  int(1)
}

— negative array indexes are a thing in PHP.

[Xenira]

— negative array indexes are a thing in PHP.

I hate PHP with a passion for their "arrays". Wish they had arrays... Actually what got me started contributing here.

I will have a look, but prob. not this release (unless someone contributes), as I don't think this is a regression.

[kakserpom]

Yeah, man, so do I. There should be dictionaries and vectors instead.

It's a pretty straightforward fix, I am working on it.