Skip to content

Conversation

@hugo-a-garcia
Copy link

The dependencies updates happened when I did a 'npm link'. I ran 'npm audit fix' and it corrected all dependencies except:

1 vulnerability required manual review and could not be updated
1 package update for 42 vulnerabilities involved breaking changes

@davedoesdev
Copy link
Owner

@hugo-a-garcia thanks! I'll see if I can update them "by hand" and fix the npm audit

@davedoesdev
Copy link
Owner

davedoesdev commented Oct 10, 2019

Currently seeing nodejs/node-addon-api#475 due to test should throw error if invalid name passed

@hugo-a-garcia
Copy link
Author

AHA! I the node issue might explain why it is not possible to run a loop in a worker thread???

@davedoesdev
Copy link
Owner

Possibly, I'll add a test and try it out

@davedoesdev
Copy link
Owner

@hugo-a-garcia thanks, appreciate it. Fixed in 887d5ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants