Skip to content

fix(test/integration/__init__.py): Removing Python mutable defaults from methods #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions tests/integration/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -383,15 +383,15 @@ def get_node(node_id):
return CCM_CLUSTER.nodes['node%s' % node_id]


def use_multidc(dc_list, workloads=[]):
def use_multidc(dc_list, workloads=None):
use_cluster(MULTIDC_CLUSTER_NAME, dc_list, start=True, workloads=workloads)


def use_singledc(start=True, workloads=[], use_single_interface=USE_SINGLE_INTERFACE):
def use_singledc(start=True, workloads=None, use_single_interface=USE_SINGLE_INTERFACE):
use_cluster(CLUSTER_NAME, [3], start=start, workloads=workloads, use_single_interface=use_single_interface)


def use_single_node(start=True, workloads=[], configuration_options={}, dse_options={}):
def use_single_node(start=True, workloads=None, configuration_options=None, dse_options=None):
use_cluster(SINGLE_NODE_CLUSTER_NAME, [1], start=start, workloads=workloads,
configuration_options=configuration_options, dse_options=dse_options)

Expand Down Expand Up @@ -453,10 +453,11 @@ def start_cluster_wait_for_up(cluster):


def use_cluster(cluster_name, nodes, ipformat=None, start=True, workloads=None, set_keyspace=True, ccm_options=None,
configuration_options={}, dse_options={}, use_single_interface=USE_SINGLE_INTERFACE):
configuration_options=None, dse_options=None, use_single_interface=USE_SINGLE_INTERFACE):
configuration_options = configuration_options or {}
dse_options = dse_options or {}
workloads = workloads or []
dse_cluster = True if DSE_VERSION else False
if not workloads:
workloads = []

if ccm_options is None and DSE_VERSION:
ccm_options = {"version": CCM_VERSION}
Expand Down