Skip to content

Conversation

@jaboehri
Copy link
Collaborator

@jaboehri jaboehri commented Oct 23, 2025

Closes #177

Changes

Add a method to dev/dsf/fhir/spring/config/PropertiesConfig.java which checks if DSF_DEV_FHIR_SERVER_ORGANIZATION_THUMBPRINT is set. If not set, compute the thumbprint value based on the client certificate provided by DSF_DEV_FHIR_CLIENT_CERTIFICATE and save it as a property. The method gets executed before Spring starts resolving ${...} placeholders.

How Was This Patch Tested?

  • Unit tests
  • Integration tests
  • Manual executed tests

Using the 3dic-ttp test setup:

Test without environment variable DSF_DEV_FHIR_SERVER_ORGANIZATION_THUMBPRINT
  1. docker compose down -v
  2. Remove DSF_DEV_FHIR_SERVER_ORGANIZATION_THUMBPRINT from docker-compose for dic3
  3. docker compose up -d dic3-fhir
  4. In the test setup directory: openssl x509 --in secrets/dic3.crt --noout --fingerprint --sha512
  5. Compare against the organization's thumbprint under https://dic3/fhir/Organization
  6. Thumbprints match
Test with environment variable DSF_DEV_FHIR_SERVER_ORGANIZATION_THUMBPRINT
  1. docker compose down -v
  2. Add DSF_DEV_FHIR_SERVER_ORGANIZATION_THUMBPRINT to docker-compose for dic3 with value '11111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111'
  3. docker compose up -d dic3-fhir
  4. Verify that the organization's thumbprint under https://dic3/fhir/Organization equals 11111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111
  5. Thumbprints match

…T_CERTIFICATE if the DSF_DEV_FHIR_SERVER_ORGANIZATION_THUMBPRINT is omitted in the configuration
@jaboehri jaboehri requested a review from hhund October 23, 2025 14:53
@jaboehri jaboehri self-assigned this Oct 23, 2025
@jaboehri jaboehri added the enhancement New feature or request label Oct 24, 2025
@jaboehri jaboehri added this to the 2.0.0 milestone Oct 24, 2025
@jaboehri jaboehri removed their assignment Oct 24, 2025
@jaboehri jaboehri linked an issue Oct 24, 2025 that may be closed by this pull request
@jaboehri jaboehri marked this pull request as ready for review October 31, 2025 13:37
@hhund hhund self-assigned this Oct 31, 2025
Run "mvn dsf:generate-dev-setup-cert-files" to update generated .env
files.
@hhund hhund merged commit c9fc1f0 into develop_2 Oct 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't require DEV_DSF_FHIR_SERVER_ORGANIZATION_THUMBPRINT

3 participants