-
Notifications
You must be signed in to change notification settings - Fork 9
Issue/204 207 trusted cas #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Default trusted CAs (root, issuing or chains - root and issuing) are now stored as separate files in folders of the bpe, bpe_proxy, fhir and fhir_proxy docker images. The config parameters of the fhir and bpe servers can be configured with a folder containing (*.pem, *.crt) files or a single file with multiple pem encoded CAs. By default a folder is configured, allowing additions or full override via docker bind mount, but a single custom file can still be configured. The fhir_proxy and bpe_proxy images have now default folders configured via the SSL_CA_DN_REQUEST_PATH and SSL_CA_CERTIFICATE_PATH environment variables. The matching ..._PATH variables are ignored if SSL_CA_DN_REQUEST_FILE or SSL_CA_CERTIFICATE_FILE point to existing files. This change also enablsd addition or replacement via docker bind mount and configuration of single files via the ...FILE variables. The symlinks with sha1 hashes of a canonicalized form of the subject DN string needed for apache httpd are created during container startup.
BPE should not crash if a process plugins has a miss configured ProcessPluginDefinition that breaks the jvm service loader, but specific plugin should be ignored.
Adds new FhirClientConfigProvider to the API with access to client configs (moved from FhirClientProvider), the default client config trust store and a method to create a SSLContext based on the default trust store. New integration test for config provider.
* disabled annotation processor from log4j2-core by disabling all annotations processors in modules with a log42-core dependency * mockito-core configured as java agent for tests in modules where needed * added missing deprecation annotations * fixed bad method signatures in classes implementing HAPIs IValidationSupport interface * removed not needed method with potentially unsafe var-arg * configured maven-resources-plugin propertyEncoding and fixed BuildInfoReaderImpl to use UTF-8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question concerning the changes in AbstractCertificateConfig#createKeyStore: why is the first cert expected to be a client cert?
The private Nevertheless renamed to createClientKeyStore via 95b95e3 |
Default trusted CAs are now stored as separate files.
SSL_CA_DN_REQUEST_PATHandSSL_CA_CERTIFICATE_PATHenvironment variables. The matching..._PATHvariables are ignored ifSSL_CA_DN_REQUEST_FILEorSSL_CA_CERTIFICATE_FILEpoint to existing files. This change also enables addition or replacement via docker bindmount and configuration of single files via the
...FILEvariables.FhirClientConfigProviderto the API with access to client configs (moved from FhirClientProvider), the default client config trust store and a method to create an SSLContext based on the default trust store.closes #204
closes #207