-
Notifications
You must be signed in to change notification settings - Fork 9
Issue/78 210 284 remove camunda from api v2 #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hhund
merged 11 commits into
develop_2
from
issue/78_210_284_Remove_Camunda_from_API_v2
Mar 26, 2025
Merged
Issue/78 210 284 remove camunda from api v2 #290
hhund
merged 11 commits into
develop_2
from
issue/78_210_284_Remove_Camunda_from_API_v2
Mar 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Partial fix for the _profile FHIR server search parameter. TODO reimplement all URI search parameters according to the FHIR specification. * Remove camnuda-engine dependency from dsf-bpe-process-api-v2 module, v2-impl needs camunda-engine dependency. * ProcesPlugin interface now has methods to create JavaDelegate and Listener objects. The v1 implementation returns objects from the plugin, the v2 implementation return delegates to the v2 non camnuda interfaces. * Interfaces defined for Service Tasks, Execution Listeners, User Task Listeners, Message Send Tasks, Message Intermediate Throw Events and Message End Events. * New error handling mechanism for service tasks, listeners and events with default implementations. * New default send task implementation via default getter-method on event interfaces and message send task interface. * Access to local variables added to Variables interface. * New serializer for Jackson annotated pojos with setJsonVariable and setJsonVariableLocal methods on Variables interface. * Remove getVariables method from ProcessPluginApi as a Variables object should no be provided in all relevant locations. * Additional test for the v2 test plugin
This was
linked to
issues
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
schwzr
approved these changes
Mar 25, 2025
...bpe/dsf-bpe-process-api-v2/src/main/java/dev/dsf/bpe/v2/activity/task/DefaultTaskSender.java
Outdated
Show resolved
Hide resolved
dsf-bpe/dsf-bpe-process-api-v2/src/main/java/dev/dsf/bpe/v2/activity/task/TaskSender.java
Outdated
Show resolved
Hide resolved
...pe/dsf-bpe-process-api-v2/src/main/java/dev/dsf/bpe/v2/activity/DefaultUserTaskListener.java
Outdated
Show resolved
Hide resolved
dsf-bpe/dsf-bpe-process-api-v2/src/main/java/dev/dsf/bpe/v2/variables/Variables.java
Outdated
Show resolved
Hide resolved
dsf-bpe/dsf-bpe-process-api-v2-impl/src/main/java/dev/dsf/bpe/v2/plugin/ProcessPluginImpl.java
Outdated
Show resolved
Hide resolved
dsf-bpe/dsf-bpe-process-api-v2-impl/src/main/java/dev/dsf/bpe/v2/plugin/ProcessPluginImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed camunda from v2 api, improved user task listener, local variables
_profileFHIR server search parameter. TODO re-implement all URI search parameters according to the FHIRspecification.
closes #78
closes #210
closes #284